Skip to content

nixos/cassandra: Port test to python#72897

Merged
flokli merged 1 commit intoNixOS:masterfrom
JohnAZoidberg:python-port-cassandra-test
Nov 8, 2019
Merged

nixos/cassandra: Port test to python#72897
flokli merged 1 commit intoNixOS:masterfrom
JohnAZoidberg:python-port-cassandra-test

Conversation

@JohnAZoidberg
Copy link
Copy Markdown
Member

@JohnAZoidberg JohnAZoidberg commented Nov 6, 2019

Motivation for this change

#72828

Things done

nix-build nixos/tests/cassandra.nix prints

...
(109.46 seconds)
(130.68 seconds)
(359.99 seconds)
9 out of 9 tests succeeded
test script finished in 360.14s
cleaning up
killing cass0 (pid 22390)
killing cass1 (pid 22503)
killing cass2 (pid 22589)
(0.01 seconds)
/nix/store/j3ilad34hsp88m8zxsd5lz1nxcf8a19r-vm-test-run-cassandra-ci
Notify maintainers

cc myself

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 6, 2019
@tfc tfc mentioned this pull request Nov 6, 2019
Closed
@mmahut
Copy link
Copy Markdown
Member

mmahut commented Nov 7, 2019

@GrahamcOfBorg test cassandra

mmahut
mmahut reviewed Nov 7, 2019
View reviewed changes
nixos/tests/cassandra.nix Outdated
Copy link
Copy Markdown
Member

@mmahut mmahut Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
};

worldofpeace
worldofpeace reviewed Nov 7, 2019
View reviewed changes
nixos/tests/cassandra.nix Outdated
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this like jmx ports? the case like PortS seems incorrect.

Copy link
Copy Markdown
Member Author

@JohnAZoidberg JohnAZoidberg Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah okay, I changed it to jmxPortStr. That should be clearer :)

@JohnAZoidberg JohnAZoidberg force-pushed the python-port-cassandra-test branch from 2b3cadd to 25c2506 Compare November 7, 2019 21:40
@mmahut
Copy link
Copy Markdown
Member

mmahut commented Nov 8, 2019

@GrahamcOfBorg test cassandra

@flokli flokli merged commit cbb8b6d into NixOS:master Nov 8, 2019
@JohnAZoidberg JohnAZoidberg deleted the python-port-cassandra-test branch November 8, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mmahut mmahut mmahut left review comments

@worldofpeace worldofpeace worldofpeace left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JohnAZoidberg @mmahut @worldofpeace @flokli