Skip to content

home-assistant: add support for python_script component#70258

Merged
peterhoeg merged 2 commits intoNixOS:masterfrom
oneingan:restrictedpython
Jan 9, 2020
Merged

home-assistant: add support for python_script component#70258
peterhoeg merged 2 commits intoNixOS:masterfrom
oneingan:restrictedpython

Conversation

@oneingan
Copy link
Copy Markdown
Contributor

@oneingan oneingan commented Oct 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dotlambda

@oneingan oneingan requested a review from FRidh as a code owner October 2, 2019 15:21
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 2, 2019
@oneingan oneingan requested a review from jonringer as a code owner November 7, 2019 15:08
jonringer
jonringer reviewed Nov 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the commit history messed up? looks like your first commit tries to add the package that doesnt exist yet

@oneingan
Copy link
Copy Markdown
Contributor Author

oneingan commented Nov 7, 2019

I make the package and run parse_requirements.py locally both, and then make 2 commits. The result is ok. Then only mess is now, rerunning parse_requirementes.py add python-vlc. I think somebody forget to run it in another PR.

@jonringer
Copy link
Copy Markdown
Contributor

jonringer commented Nov 7, 2019

hmm, very possible

@oneingan
Copy link
Copy Markdown
Contributor Author

oneingan commented Dec 3, 2019

Is there something I can do to merge this?

@peterhoeg
Copy link
Copy Markdown
Member

peterhoeg commented Jan 9, 2020

Looks good!

@peterhoeg peterhoeg merged commit 0cffec3 into NixOS:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

1 more reviewer

@jonringer jonringer jonringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oneingan @jonringer @peterhoeg