Skip to content

home-assistant: 0.96.2 -> 0.99.2#69395

Merged
etu merged 1 commit intoNixOS:masterfrom
peterhoeg:u/ha_0992
Sep 25, 2019
Merged

home-assistant: 0.96.2 -> 0.99.2#69395
etu merged 1 commit intoNixOS:masterfrom
peterhoeg:u/ha_0992

Conversation

@peterhoeg
Copy link
Copy Markdown
Member

@peterhoeg peterhoeg commented Sep 25, 2019

Motivation for this change

https://www.home-assistant.io/blog/2019/09/18/release-99/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dotlambda

@ofborg ofborg bot requested review from dotlambda and globin September 25, 2019 00:29
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 25, 2019
jonringer
jonringer approved these changes Sep 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf packge

@etu etu merged commit 2436c27 into NixOS:master Sep 25, 2019
@peterhoeg peterhoeg deleted the u/ha_0992 branch September 26, 2019 05:10
@peterhoeg peterhoeg restored the u/ha_0992 branch September 27, 2019 00:57
This was referenced Sep 29, 2019
Closed
Closed
@peterhoeg peterhoeg deleted the u/ha_0992 branch October 21, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@globin globin Awaiting requested review from globin

@dotlambda dotlambda Awaiting requested review from dotlambda

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterhoeg @jonringer @etu