Skip to content

steam chrootenv: add lsb-release#65822

Merged
abbradar merged 1 commit intoNixOS:masterfrom
davidak:steam-lsb-release1
Aug 9, 2019
Merged

steam chrootenv: add lsb-release#65822
abbradar merged 1 commit intoNixOS:masterfrom
davidak:steam-lsb-release1

Conversation

@davidak
Copy link
Copy Markdown
Member

@davidak davidak commented Aug 2, 2019 •
edited
Loading

Motivation for this change

Fixes #63839

issue with operating system detection
sh: lsb_release: command not found

With this change it works!

steam-nixos

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar

@davidak
steam chrootenv: add lsb-release
7db3602 
Fixes issue with operating system detection
sh: lsb_release: command not found
@ofborg ofborg bot added 6.topic: steam Steam game store/launcher (store.steampowered.com) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 2, 2019
@abbradar
Copy link
Copy Markdown
Member

abbradar commented Aug 9, 2019

Nice, thanks!

@abbradar abbradar merged commit d568509 into NixOS:master Aug 9, 2019
@davidak davidak deleted the steam-lsb-release1 branch August 9, 2019 10:52
@davidak davidak mentioned this pull request Aug 14, 2019
Closed
@Tiagoquix Tiagoquix mentioned this pull request Nov 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teto teto teto approved these changes

Assignees

No one assigned

Labels

6.topic: steam Steam game store/launcher (store.steampowered.com) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Steam unable to detect OS (NixOS)

3 participants

@davidak @abbradar @teto