Skip to content

[RFC] Stop writing to obsolete /proc/sys/kernel/hotplug#6282

Closed
nckx wants to merge 1 commit intoNixOS:masterfrom
nckx:obsolete-hotplug
Closed

[RFC] Stop writing to obsolete /proc/sys/kernel/hotplug#6282
nckx wants to merge 1 commit intoNixOS:masterfrom
nckx:obsolete-hotplug

Conversation

@nckx
Copy link
Copy Markdown
Member

@nckx nckx commented Feb 10, 2015

It's been deprecated since 2006 and spews errors on custom kernels. NixOS doesn't use it. Arch doesn't have it.

Any legitimate users left?

@edolstra
Copy link
Copy Markdown
Member

IIRC, we clear that file to prevent the kernel from trying to call /sbin/hotplug. A quick look at the kernel sources suggests that this is still required. (Though we could also clear CONFIG_UEVENT_HELPER_PATH at build time, I think.)

@nckx
Copy link
Copy Markdown
Member Author

nckx commented Feb 11, 2015

TBH, I'd rather get rid of the whole CONFIG_UEVENT_HELPER* legacy in the kernel as well. I've a patch to do just that at home, but it seems to have escaped the PR. Would that be all right?

(It was never a great design to begin with, and really doesn't seem like something that should be enabled by default anymore. From Kconfig:

Before the switch to the netlink-based uevent source, this was used to hook hotplug scripts into kernel device events. [...] This should not be used today)

@edolstra
Copy link
Copy Markdown
Member

Yeah, if there is a kernel option to disable uevent helper stuff, that would be great.

@nckx
Copy link
Copy Markdown
Member Author

nckx commented Feb 11, 2015

To disable it, I need to set UEVENT_HELPER_PATH to the empty string. How can I do that? "" doesn't work.

@acertain
Copy link
Copy Markdown
Contributor

CONFIG_UEVENT_HELPER disables the uevent helper, and also /proc/sys/kernel/hotplug, I don't know what version it became available in, but it's in 3.19.0

@nckx
Copy link
Copy Markdown
Member Author

nckx commented Feb 26, 2015

I seem to remember some obscure Dell driver that still requires that option, though...?

Never mind, that was FW_LOADER_USER_HELPER, not this... Pushed as 9f87f3c.

@nckx nckx closed this Mar 1, 2015
@nckx nckx deleted the obsolete-hotplug branch March 1, 2015 03:14
@nbp nbp mentioned this pull request Feb 26, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants