awesome: add optional gtk3 support#61161
Merged
rasendubi merged 1 commit intoNixOS:masterfrom May 11, 2019
stefano-m:awesome-issue-60538
Merged
awesome: add optional gtk3 support#61161rasendubi merged 1 commit intoNixOS:masterfrom stefano-m:awesome-issue-60538
rasendubi merged 1 commit intoNixOS:masterfrom
stefano-m:awesome-issue-60538
Conversation
Contributor
Author
|
It would be nice if this could be backported to 19.03 as it's backwards-compatible. Thanks. |
10 tasks
Member
|
@GrahamcOfBorg build awesome |
jtojnar
reviewed
May 8, 2019
Add optional gtk3 support to Awesome so that the `beautiful.gtk` module can be
used.
The `beautiful.gtk` uses `lgi` to obtain Gtk via gobject-introspect:
return require('lgi').Gtk
Since the current build does not include the typelib files needed, the above
call fails.
It turns out that both `gtk3` and `atk` (Accessibility toolkit) are needed, so
this commit adds them as optional build inputs.
Setting `gtk3Support` to `true` e.g. in an overlay will make `beautiful.gtk`
work at the cost of an increased closure size (currently 99.6M vs 223.4M).
Fixes #60538
Contributor
Author
|
@jtojnar @rasendubi I have fixed the conflicts that occurred while waiting for the merge. Rebuilding caused no issues at all. Hopefully this might go in soon if you agree. Thanks. |
Member
|
Thank you! We could also add awesome with gtk3 support to |
Contributor
Author
|
Thanks @rasendubi, any chance at all this can land in the 19.03 branch?
Cool, if I get time I can whip up an PR for that. |
Member
|
@stefano-m yeah, I don't see why not. Just submit a PR against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add optional gtk3 support to Awesome so that the
beautiful.gtkmodule can beused.
The
beautiful.gtkuseslgito obtain Gtk via gobject-introspect:Since the current build does not include the typelib files needed, the above
call fails.
It turns out that both
gtk3andatk(Accessibility toolkit) are needed, sothis commit adds them as optional build inputs.
Setting
gtk3Supporttotruee.g. in an overlay will makebeautiful.gtkwork at the cost of an increased closure size (currently 99.6M vs 223.4M).
Fixes #60538
Things done
nix.useSandboxon NixOS, or optionsandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)