Skip to content

python.pkgs.pyasn1-modules: fix python2 tests#60618

Merged
timokau merged 1 commit intoNixOS:staging-nextfrom
timokau:pyasn1-modules-py2-fix
May 1, 2019
Merged

python.pkgs.pyasn1-modules: fix python2 tests#60618
timokau merged 1 commit intoNixOS:staging-nextfrom
timokau:pyasn1-modules-py2-fix

Conversation

@timokau
Copy link
Copy Markdown
Member

@timokau timokau commented May 1, 2019 •
edited
Loading

Motivation for this change

Broken by the update in e03d551.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner May 1, 2019 10:06
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 1, 2019
@timokau timokau merged commit 7909ed1 into NixOS:staging-next May 1, 2019
@timokau timokau deleted the pyasn1-modules-py2-fix branch May 1, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@timokau