Skip to content

pythonPackages.asyncssh: 1.15.1 -> 1.16.1#60096

Merged
worldofpeace merged 1 commit intoNixOS:stagingfrom
worldofpeace:asyncssh-bump
Apr 24, 2019
Merged

pythonPackages.asyncssh: 1.15.1 -> 1.16.1#60096
worldofpeace merged 1 commit intoNixOS:stagingfrom
worldofpeace:asyncssh-bump

Conversation

@worldofpeace
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace commented Apr 23, 2019

https://github.com/ronf/asyncssh/blob/master/docs/changes.rst#release-1161-30-mar-2019

Motivation for this change

Been waiting forever to pr this 🤣

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from FRidh as a code owner April 23, 2019 15:01
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 23, 2019
dotlambda
dotlambda requested changes Apr 24, 2019
View reviewed changes
pkgs/development/python-modules/asyncssh/default.nix Outdated
Copy link
Copy Markdown
Member

@dotlambda dotlambda Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use fetchpatch with revert = true?

Copy link
Copy Markdown
Contributor Author

@worldofpeace worldofpeace Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried and it wouldn't apply...

@worldofpeace worldofpeace merged commit 76e7783 into NixOS:staging Apr 24, 2019
@worldofpeace worldofpeace deleted the asyncssh-bump branch April 24, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@worldofpeace @dotlambda