Skip to content

nmapsi4: 0.5.0-alpha1 -> 0.4.80-20180430#59266

Merged
peterhoeg merged 1 commit intoNixOS:masterfrom
peterhoeg:u/nmapqt
Apr 17, 2019
Merged

nmapsi4: 0.5.0-alpha1 -> 0.4.80-20180430#59266
peterhoeg merged 1 commit intoNixOS:masterfrom
peterhoeg:u/nmapqt

Conversation

@peterhoeg
Copy link
Copy Markdown
Member

@peterhoeg peterhoeg commented Apr 10, 2019

Motivation for this change

0.5.0-alpha1 was released years ago but that actual latest test version (stable doesn't work with qt5) makes things work with recent qt5 as well as replaces qtwebkit with qtwebengine, so we definitely want that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg self-assigned this Apr 10, 2019
@GrahamcOfBorg GrahamcOfBorg added 8.has: clean-up This PR removes packages or removes other cruft 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 10, 2019
@veprbl veprbl mentioned this pull request Apr 10, 2019
Closed
69 tasks
@peterhoeg peterhoeg merged commit 569d94f into NixOS:master Apr 17, 2019
@peterhoeg peterhoeg deleted the u/nmapqt branch April 17, 2019 07:49
@peterhoeg peterhoeg restored the u/nmapqt branch April 17, 2019 08:05
@peterhoeg peterhoeg deleted the u/nmapqt branch April 25, 2019 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@peterhoeg peterhoeg

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peterhoeg @GrahamcOfBorg