Skip to content

Fixes several broken python packages for python-unstable#56312

Merged
dotlambda merged 7 commits intoNixOS:staging-nextfrom
costrouc:python-unstable
Feb 25, 2019
Merged

Fixes several broken python packages for python-unstable#56312
dotlambda merged 7 commits intoNixOS:staging-nextfrom
costrouc:python-unstable

Conversation

@costrouc
Copy link
Copy Markdown
Member

@costrouc costrouc commented Feb 24, 2019

Motivation for this change

#55757

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc changed the title Fixes for broken python packages for python-unstable Fixes several broken python packages for python-unstable Feb 24, 2019
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 24, 2019
@costrouc costrouc changed the base branch from master to python-unstable February 24, 2019 22:26
@dotlambda dotlambda changed the base branch from python-unstable to staging-next February 24, 2019 22:46
@dotlambda
Copy link
Copy Markdown
Member

dotlambda commented Feb 24, 2019

"depreciated" -> "deprecated"

@dotlambda dotlambda removed the request for review from ryantm February 24, 2019 22:47
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: pantheon The Pantheon desktop environment 6.topic: stdenv Standard environment 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 24, 2019
dotlambda
dotlambda requested changes Feb 24, 2019
View reviewed changes
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 24, 2019
@costrouc costrouc force-pushed the python-unstable branch 2 times, most recently from 36e5227 to be06dd7 Compare February 24, 2019 23:46
dotlambda
dotlambda reviewed Feb 25, 2019
View reviewed changes
dotlambda
dotlambda reviewed Feb 25, 2019
View reviewed changes
@dotlambda
Copy link
Copy Markdown
Member

dotlambda commented Feb 25, 2019

Two further things that should be changed in your commit messages:

  • "depreciated" -> "deprecated"
  • pythonPackages.monty: 1.0.2 -> 1.0.4

@dotlambda
Copy link
Copy Markdown
Member

dotlambda commented Feb 25, 2019

I did the changes myself. Please have a look at the changes I made to shapely.

@costrouc
Copy link
Copy Markdown
Member Author

costrouc commented Feb 25, 2019

@dotlambda looks good to me! Sorry didn't have time this morning to make the edits

@dotlambda dotlambda merged commit 0dbfd0e into NixOS:staging-next Feb 25, 2019
@dotlambda
Copy link
Copy Markdown
Member

dotlambda commented Feb 25, 2019

Sorry didn't have time this morning to make the edits

No problem. Thank you very much for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@costrouc @dotlambda @GrahamcOfBorg