Skip to content

pythonPackages.pykerberos: take krb5 as a nativeBuildInput#56268

Merged
dotlambda merged 1 commit intoNixOS:staging-nextfrom
catern:pykn
Feb 24, 2019
Merged

pythonPackages.pykerberos: take krb5 as a nativeBuildInput#56268
dotlambda merged 1 commit intoNixOS:staging-nextfrom
catern:pykn

Conversation

@catern
Copy link
Copy Markdown
Contributor

@catern catern commented Feb 23, 2019 •
edited
Loading

Motivation for this change

Fixes build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@catern catern requested a review from FRidh as a code owner February 23, 2019 22:49
@catern catern mentioned this pull request Feb 23, 2019
Merged
10 tasks
@GrahamcOfBorg GrahamcOfBorg added 6.topic: python Python is a high-level, general-purpose programming language. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 23, 2019
@dotlambda dotlambda changed the base branch from staging to staging-next February 24, 2019 07:16
@dotlambda
Copy link
Copy Markdown
Member

dotlambda commented Feb 24, 2019 •
edited
Loading

Please rebase on staging-next.
EDIT: Did it myself :)

dotlambda
dotlambda approved these changes Feb 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that nix-shell -I nixpkgs=. -p "python3.withPackages (ps: with ps; [ pykerberos ])" --run "python -c 'import kerberos'" now works.

@dotlambda dotlambda merged commit 917f6f9 into NixOS:staging-next Feb 24, 2019
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 24, 2019
@catern catern deleted the pykn branch February 24, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@catern @dotlambda @GrahamcOfBorg