Skip to content

skrooge: remove QtWebKit dependency#55930

Merged
veprbl merged 1 commit intoNixOS:masterfrom
alapshin:skrooge
Feb 17, 2019
Merged

skrooge: remove QtWebKit dependency#55930
veprbl merged 1 commit intoNixOS:masterfrom
alapshin:skrooge

Conversation

@alapshin
Copy link
Copy Markdown
Contributor

@alapshin alapshin commented Feb 17, 2019

Motivation for this change

Remove QtWebkit dependency introduced in
a1b8fe8

It is no longer needed after upstream fix
https://cgit.kde.org/skrooge.git/commit/?id=cb8b56fa729d5f6ee4652e79de354721f4742ee7

Corresponding check in #53079 could be updated after this PR is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alapshin
skrooge: remove QtWebKit dependency
7460b95 
Remove QtWebkit dependency introduced in
a1b8fe8

It is no longer needed after upstream fix
https://cgit.kde.org/skrooge.git/commit/?id=cb8b56fa729d5f6ee4652e79de354721f4742ee7
@GrahamcOfBorg GrahamcOfBorg requested a review from jokogr February 17, 2019 07:29
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 17, 2019
@veprbl veprbl mentioned this pull request Feb 17, 2019
Closed
69 tasks
@veprbl
Copy link
Copy Markdown
Member

veprbl commented Feb 17, 2019

cc @jokogr
@GrahamcOfBorg build skrooge

veprbl
veprbl approved these changes Feb 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@veprbl veprbl merged commit b94bdd8 into NixOS:master Feb 17, 2019
@alapshin alapshin deleted the skrooge branch February 17, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

@jokogr jokogr Awaiting requested review from jokogr

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alapshin @veprbl @GrahamcOfBorg