nixos/flannel: add kubernetes as storage backend (and fix test)#55649
Merged
offlinehacker merged 3 commits intoNixOS:masterfrom Feb 15, 2019
Merged
nixos/flannel: add kubernetes as storage backend (and fix test)#55649offlinehacker merged 3 commits intoNixOS:masterfrom
offlinehacker merged 3 commits intoNixOS:masterfrom
Conversation
Contributor
Author
|
@GrahamcOfBorg test flannel |
Contributor
|
@GrahamcOfBorg test flannel |
Contributor
|
Oh, it's not even exposed in the release set. |
Contributor
Author
|
@srhb I added the test to the release set in this PR :) |
…ith kubernetes storage backend
Contributor
Author
|
Added an extra option @GrahamcOfBorg test flannel |
Contributor
Author
|
relates to #45670 |
9 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Flannel can now use the kubernetes api as storage backend, instead of etcd. This is useful especially when deploying flannel with kubernetes where you - otherwise - either need to allow multi-user access to a single etcd instance or setup a secondary etcd instance just to hold flannel config. When configuring flannel with kubernetes as storage backend, you can isolate the access to etcd by authorizing only kube-apiserver.
backward compatibility: The default behavior is unchanged. Etcd will be used as storage backend, unless the new option
services.flannel.storageBackendis set tokubernetes.furthermore: the flannel test case fails on master. etcd refuses to startup, because it requires ip-adresses configured as listening adresses in order to determine which interfaces to bind to. Fixed that as part of this PR.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)