Skip to content

toggldesktop: bump qt-oauth-lib (see #53676)#54587

Merged
veprbl merged 1 commit intoNixOS:masterfrom
transumption:201901/qt-oauth-lib
Jan 25, 2019
Merged

toggldesktop: bump qt-oauth-lib (see #53676)#54587
veprbl merged 1 commit intoNixOS:masterfrom
transumption:201901/qt-oauth-lib

Conversation

@lukateras
Copy link
Copy Markdown
Member

@lukateras lukateras commented Jan 25, 2019

Motivation for this change

Fixes #53676.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukateras lukateras mentioned this pull request Jan 25, 2019
Closed
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 25, 2019
@veprbl veprbl mentioned this pull request Jan 25, 2019
Closed
69 tasks
veprbl
veprbl approved these changes Jan 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this just enough to see that "Login with google" successfully opens an oauth page.
Thank you!

@veprbl veprbl merged commit 6f5bb35 into NixOS:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukateras @veprbl @GrahamcOfBorg