Skip to content

bash,readline80: upgrade bash 4 -> 5, init readline80#53687

Closed
dtzWill wants to merge 1 commit intoNixOS:stagingfrom
dtzWill:experimental/bash5-default
Closed

bash,readline80: upgrade bash 4 -> 5, init readline80#53687
dtzWill wants to merge 1 commit intoNixOS:stagingfrom
dtzWill:experimental/bash5-default

Conversation

@dtzWill
Copy link
Copy Markdown
Member

@dtzWill dtzWill commented Jan 9, 2019

Motivation for this change

Essentially same as #53628 only rebased to staging
and instead of (temporary?) top-level variants
go ahead and make it the default.

Naturally needs to be tested carefully first!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Copy Markdown
Member Author

dtzWill commented Jan 9, 2019

This makes it the default, per your suggestion @Mic92 :).

Also looks like my concerns about breakage were warranted, our stdenv's consumeEntire seems not to work with this:

consumeEntire(): ERROR: Input null bytes, won't process

cc stdenv maintainers: @Ericson2314 @matthewbauer

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 9, 2019
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Jan 9, 2019

You might want to cherry-pick: 26c7c59

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Jan 17, 2019

Now this one can be rebased.

@dtzWill dtzWill force-pushed the experimental/bash5-default branch from 7fabff1 to ee5071c Compare January 17, 2019 16:26
@GrahamcOfBorg GrahamcOfBorg added 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 17, 2019
@dtzWill dtzWill force-pushed the experimental/bash5-default branch from ee5071c to 8e98a33 Compare January 20, 2019 08:14
@dtzWill
Copy link
Copy Markdown
Member Author

dtzWill commented Jan 20, 2019

See also #54353 FWIW.

@GrahamcOfBorg GrahamcOfBorg removed 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 20, 2019
@GrahamcOfBorg GrahamcOfBorg added 8.has: clean-up This PR removes packages or removes other cruft and removed 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 20, 2019
@FRidh FRidh added this to the 19.09 milestone Apr 28, 2019
@FRidh
Copy link
Copy Markdown
Member

FRidh commented Apr 28, 2019

@dtzWill should this be closed?

@abathur abathur mentioned this pull request May 17, 2019
Closed
@ttuegel ttuegel removed their request for review September 28, 2019 11:58
@FRidh
Copy link
Copy Markdown
Member

FRidh commented Nov 24, 2019

Nothing happening so closing.

@FRidh FRidh closed this Nov 24, 2019
@happysalada happysalada mentioned this pull request Aug 2, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@lovek323 lovek323 Awaiting requested review from lovek323

@andir andir Awaiting requested review from andir

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

19.09

Development

Successfully merging this pull request may close these issues.

4 participants

@dtzWill @Mic92 @FRidh @GrahamcOfBorg