Skip to content

digikam: switch from QtWebKit to QtWebEngine#53083

Merged
FRidh merged 1 commit intoNixOS:masterfrom
veprbl:pr/digikam_use_qtwebengine
Dec 31, 2018
Merged

digikam: switch from QtWebKit to QtWebEngine#53083
FRidh merged 1 commit intoNixOS:masterfrom
veprbl:pr/digikam_use_qtwebengine

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented Dec 30, 2018 •
edited
Loading

Motivation for this change

QtWebKit is deprecated since Qt 5.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl mentioned this pull request Dec 30, 2018
Closed
69 tasks
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 30, 2018
@FRidh FRidh merged commit 00754cd into NixOS:master Dec 31, 2018
@veprbl veprbl deleted the pr/digikam_use_qtwebengine branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@veprbl @FRidh @GrahamcOfBorg