Skip to content

emmet-language-server: migrate to pnpm_11, add test, refactor#530542

Merged
gepbird merged 4 commits into
NixOS:masterfrom
gepbird:emmet-language-server-newer-pnpm
Jun 11, 2026
Merged

emmet-language-server: migrate to pnpm_11, add test, refactor#530542
gepbird merged 4 commits into
NixOS:masterfrom
gepbird:emmet-language-server-newer-pnpm

Conversation

@gepbird

@gepbird gepbird commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Part of #529285

Things done

@gepbird gepbird mentioned this pull request Jun 10, 2026
54 tasks
@gepbird gepbird requested a review from qweered June 10, 2026 23:19
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jun 10, 2026
@gepbird gepbird changed the title emmet-language-server: migrate from pnpm_9 to pnpm_11 emmet-language-server: migrate to pnpm_11, add test, refactor Jun 10, 2026
@gepbird gepbird force-pushed the emmet-language-server-newer-pnpm branch from fb16737 to 0ee9fde Compare June 10, 2026 23:40
This was taken from vtsls.
@gepbird gepbird force-pushed the emmet-language-server-newer-pnpm branch from 0ee9fde to 888551d Compare June 10, 2026 23:42
@qweered

qweered commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha (d350d81)

Command: nixpkgs-review pr 530542
Commit: 888551d011f058cfa314db0307fbc805e71f6214 (subsequent changes)
Merge: d676530f0955779c9900326685bcc733b2523bf6

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/27342870435/attempts/1


x86_64-linux

✅ 1 package built:
  • emmet-language-server

aarch64-linux

✅ 1 package built:
  • emmet-language-server

aarch64-darwin (sandbox = false)

❌ 1 package failed to build:
  • emmet-language-server

@qweered

qweered commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Logs from aarch64-darwin:

emmet-language-server-pnpm-deps> (node:14387) Warning: File descriptor 46 opened in unmanaged mode twice
emmet-language-server-pnpm-deps> (node:14387) Warning: File descriptor 46 closed but not opened in unmanaged mode

@gepbird

gepbird commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Logs from aarch64-darwin:

emmet-language-server-pnpm-deps> (node:14387) Warning: File descriptor 46 opened in unmanaged mode twice
emmet-language-server-pnpm-deps> (node:14387) Warning: File descriptor 46 closed but not opened in unmanaged mode

I believe this fails on most darwin machines but passes on the Hydra builder. I had a similar experience which I documented in #524812 (comment).
TLDR: #525627 is about this, a PR currently in staging should fix it.

@gepbird gepbird added this pull request to the merge queue Jun 11, 2026
Merged via the queue into NixOS:master with commit 63bf5f9 Jun 11, 2026
27 checks passed
@gepbird gepbird deleted the emmet-language-server-newer-pnpm branch June 11, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants