Skip to content

rquickshare: pin pnpm to v10#529495

Merged
khaneliman merged 1 commit into
NixOS:masterfrom
PerchunPak:rquickshare
Jun 9, 2026
Merged

rquickshare: pin pnpm to v10#529495
khaneliman merged 1 commit into
NixOS:masterfrom
PerchunPak:rquickshare

Conversation

@PerchunPak

@PerchunPak PerchunPak commented Jun 8, 2026

Copy link
Copy Markdown
Member

pnpm 9 is EOL now (see #529285)

Things done

@PerchunPak PerchunPak added the backport release-26.05 Backport PR automatically label Jun 8, 2026
PerchunPak
PerchunPak commented Jun 8, 2026
View reviewed changes
Comment thread pkgs/by-name/rq/rquickshare/remove-duplicate-versions-of-sys-metrics.patch

@PerchunPak PerchunPak Jun 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch used to be needed because of a bug in fetchCargoVendor, but it is fixed now

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 8, 2026
sarunint
sarunint approved these changes Jun 8, 2026
View reviewed changes

@sarunint sarunint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PerchunPak

This comment was marked as outdated.

Sign in to view
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 8, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 8, 2026
@RossSmyth

RossSmyth commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Unpinning pnpm is generally not a good idea as pnpm breaks with major versions fairly frequently. Since upstreams often do not track pnpm as closely as nixpkgs, it is a good idea to pin to whatever upstream uses rather than unpinning.

@PerchunPak

PerchunPak commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Unpinning pnpm is generally not a good idea as pnpm breaks with major versions fairly frequently. Since upstreams often do not track pnpm as closely as nixpkgs, it is a good idea to pin to whatever upstream uses rather than unpinning.

Upstream uses version 8, so I guess I should pin it to pnpm 10?
https://github.com/Martichou/rquickshare/blob/378d8ae969941bee4bf60ad34ac9cf8bb7005eb7/.github/workflows/build.yml#L67

@dotlambda dotlambda mentioned this pull request Jun 8, 2026
Open
54 tasks
@PerchunPak

PerchunPak commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

Pinned it to v10 for now

@PerchunPak PerchunPak changed the title rquickshare: unpin pnpm rquickshare: pin pnpm to v10 Jun 9, 2026
@PerchunPak

This comment was marked as outdated.

Sign in to view
@khaneliman

khaneliman commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 529495
Commit: e91e36f9f2e60ea2f059a37a771b8319b2ace958

x86_64-linux

✅ 1 package built:
  • rquickshare

aarch64-linux

✅ 1 package built:
  • rquickshare

aarch64-darwin

✅ 1 package built:
  • rquickshare

@khaneliman khaneliman added this pull request to the merge queue Jun 9, 2026
Merged via the queue into NixOS:master with commit ca8975f Jun 9, 2026
26 checks passed
@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Jun 9, 2026
Merged
@nixpkgs-ci

nixpkgs-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-26.05:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sarunint sarunint sarunint approved these changes

@luftmensch-luftmensch luftmensch-luftmensch luftmensch-luftmensch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-26.05 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PerchunPak @RossSmyth @khaneliman @sarunint @luftmensch-luftmensch