linuxPackages_4_{19,20}: works around bug with overlayfs#52942
Merged
domenkozar merged 1 commit intoNixOS:masterfrom Dec 26, 2018
Merged
linuxPackages_4_{19,20}: works around bug with overlayfs#52942domenkozar merged 1 commit intoNixOS:masterfrom
domenkozar merged 1 commit intoNixOS:masterfrom
Conversation
Member
|
@GrahamcOfBorg test boot-stage1.x86_64-linux |
Member
|
@GrahamcOfBorg test boot-stage1 |
Member
Author
|
@GrahamcOfBorg build nixosTests.boot-stage1 (I was searching whether this was fixed or not; the issue with running tests.) |
Member
Author
|
The x86_64 build timed out, the aarch64 build succeeded. Locally, here, I have verified the x86_64 build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #48828 (comment)
I ran the following:
Both with
linuxPackagesset to 4_19 (current default) and 4_20 (to make sure the other change is good).The patch is literally the one from @aszlig's comment in the linked thread, but applied as a commit on top of the linux repository; only to get it as a fetchpatch-able artifact. Though I do encourage you to load up and verify the patch.
There is no upstream issue opened yet. I don't think I'm able to work with upstream as I don't really know the details of the issue. @aszlig maybe will handle that.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @domenkozar