Skip to content

musescore: 2.3.2 -> 3.0#52835

Merged
veprbl merged 2 commits intoNixOS:masterfrom
suhr:musescore
Jan 5, 2019
Merged

musescore: 2.3.2 -> 3.0#52835
veprbl merged 2 commits intoNixOS:masterfrom
suhr:musescore

Conversation

@suhr
Copy link
Copy Markdown
Contributor

@suhr suhr commented Dec 25, 2018 •
edited
Loading

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@suhr
Copy link
Copy Markdown
Contributor Author

suhr commented Dec 25, 2018

@vandenoever

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 25, 2018
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Dec 26, 2018

@suhr You forgot to change the sha256.

This value can easily be retrieved by replacing it with a false hash like

0000000000000000000000000000000000000000000000000000

and then getting the correct hash from the output in your terminal when you build this.

@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Dec 26, 2018

Link To Release Notes
For those interested

@suhr
Copy link
Copy Markdown
Contributor Author

suhr commented Dec 26, 2018

r?

@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Dec 26, 2018

@GrahamcOfBorg build musescore

@suhr
Copy link
Copy Markdown
Contributor Author

suhr commented Dec 28, 2018

Is it ok to merge?

@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Dec 28, 2018

Currently fails to build https://logs.nix.ci/?key=nixos/nixpkgs.52835&attempt_id=043dab25-345b-4cce-af09-58caa5f2491f

Needs investigation.

@veprbl
musescore: switch to QtWebEngine
fc2a653 
Since version 3.0 it builds with QtWebEngine by default.
@veprbl veprbl mentioned this pull request Jan 5, 2019
Closed
69 tasks
@veprbl
Copy link
Copy Markdown
Member

veprbl commented Jan 5, 2019

@GrahamcOfBorg build musescore

@veprbl veprbl merged commit fb185ff into NixOS:master Jan 5, 2019
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Jan 5, 2019

Thanks @veprbl for fixing the build ✨

@suhr suhr deleted the musescore branch January 5, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suhr @worldofpeace @veprbl @GrahamcOfBorg