Skip to content

deadlock-mod-manager: 0.18.0 -> 1.0.0#527745

Merged
khaneliman merged 1 commit into
NixOS:masterfrom
3L0C:deadlock-mod-manager-1.0.0
Jun 5, 2026
Merged

deadlock-mod-manager: 0.18.0 -> 1.0.0#527745
khaneliman merged 1 commit into
NixOS:masterfrom
3L0C:deadlock-mod-manager-1.0.0

Conversation

@3L0C

@3L0C 3L0C commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Updates deadlock-mod-manager to v1.0.0.

The automated update couldn't handle this release because v1.0.0 bumps the upstream package manager from pnpm 9 to pnpm 11.2.2, so pnpm_9 is switched to pnpm_11 along with the recomputed pnpmDeps/cargo/src hashes.

v1.0.0 also adds a unit test (set_steam_dir_rejects_invalid_directory) that fails in every environment: it expects set_steam_dir to reject a non-Steam directory, but steamlocate 2.1.0's SteamDir::from_dir only checks that the path is a directory (deeper validation is an upstream TODO). The test is bypassed in checkFlags with an explanatory comment.

Things done

@nixpkgs-ci nixpkgs-ci Bot requested review from Mistyttm and schromp June 3, 2026 21:23
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Jun 3, 2026
@Mistyttm

Mistyttm commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Thanks for catching that for me, it was on my to-do list to checkup on it

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 4, 2026
@khaneliman

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 527745
Commit: 62d06da64d5d8ee7945eea973f7225db056891c9


x86_64-linux

✅ 1 package built:
  • deadlock-mod-manager

aarch64-linux

✅ 1 package built:
  • deadlock-mod-manager

@khaneliman khaneliman added this pull request to the merge queue Jun 5, 2026
Merged via the queue into NixOS:master with commit 16df395 Jun 5, 2026
34 checks passed
@gepbird gepbird mentioned this pull request Jun 12, 2026
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants