Skip to content

misskey: 2025.12.2 -> 2026.5.4#527568

Merged
imincik merged 1 commit into
NixOS:masterfrom
Vonfry:update-misskey
Jun 8, 2026
Merged

misskey: 2025.12.2 -> 2026.5.4#527568
imincik merged 1 commit into
NixOS:masterfrom
Vonfry:update-misskey

Conversation

@Vonfry

@Vonfry Vonfry commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Things done

@Vonfry

Vonfry commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

With a glance through releases annotations, I didn't see any breaking changes, so no release notes is added.

Edit
I didn't run nixosTests.misskey. The vm build hung on my machine. nixosTests.misskey passed.

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 3, 2026
@Vonfry Vonfry marked this pull request as draft June 4, 2026 12:54
@Vonfry Vonfry marked this pull request as ready for review June 4, 2026 13:00
@phanirithvij phanirithvij mentioned this pull request Jun 8, 2026
Open
54 tasks
phanirithvij
phanirithvij reviewed Jun 8, 2026
View reviewed changes
Comment thread pkgs/by-name/mi/misskey/package.nix Outdated
@Vonfry Vonfry requested a review from phanirithvij June 8, 2026 11:28
phanirithvij
phanirithvij approved these changes Jun 8, 2026
View reviewed changes

@phanirithvij phanirithvij left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, thanks.

CI failures are unrelated, looks like some temporary issues with cachix.

@phanirithvij phanirithvij added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-26.05 Backport PR automatically labels Jun 8, 2026
@phanirithvij phanirithvij requested a review from imincik June 8, 2026 12:33
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 8, 2026
@eljamm eljamm closed this Jun 8, 2026
@eljamm eljamm reopened this Jun 8, 2026
@imincik

imincik commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 527568
Commit: 56555753d53f435c399ef11ba40c4e6610f678cc (subsequent changes)
Merge: f279c74966ab76477410cc6386a35ee7515a0d79

Logs: https://github.com/imincik/nixpkgs-review-gha/actions/runs/27138774828

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-527568-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://imincik-nixpkgs-review-gha.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  imincik-nixpkgs-review-gha.cachix.org-1:vbkvABMrxmQ+ObRDwmF2qaLIEhGHdbF4MwXtOPU8Jmk=
  ' \
  /nix/store/5pggvkw5l3b4gzsbcr0818q5ql1f0c3h-misskey-2026.5.4
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-527568-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://imincik-nixpkgs-review-gha.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  imincik-nixpkgs-review-gha.cachix.org-1:vbkvABMrxmQ+ObRDwmF2qaLIEhGHdbF4MwXtOPU8Jmk=
  ' \
  /nix/store/3pdm3k87pc8jidwqmyriqhw1crq15aaj-misskey-2026.5.4

x86_64-linux

✅ 1 package built:
  • misskey

aarch64-linux

✅ 1 package built:
  • misskey

x86_64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • misskey

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • misskey

@phanirithvij

phanirithvij commented Jun 8, 2026

Copy link
Copy Markdown
Member

https://hydra.nixos.org/job/nixpkgs/unstable/misskey.aarch64-darwin
https://hydra.nixos.org/job/nixpkgs/unstable/misskey.x86_64-darwin

From #525627 I gather aarch64-darwin failure might be only a github actions specific issue.

And I don't think we need to fix the x86_64-darwin in this PR itself, it was failing beforehand.

imincik
imincik approved these changes Jun 8, 2026
View reviewed changes

@imincik imincik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks.

@imincik imincik added this pull request to the merge queue Jun 8, 2026
Merged via the queue into NixOS:master with commit d9a9fe6 Jun 8, 2026
56 of 57 checks passed
@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Jun 8, 2026
Closed
@nixpkgs-ci

nixpkgs-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-26.05:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 8, 2026
This was referenced Jun 9, 2026
Merged
Merged
@Vonfry Vonfry deleted the update-misskey branch June 9, 2026 09:05
@Prince213 Prince213 linked an issue Jun 10, 2026 that may be closed by this pull request
HTTP signature verification can be bypassed #498837
Closed
@Prince213 Prince213 mentioned this pull request Jun 10, 2026
Closed
@Prince213 Prince213 linked an issue Jun 10, 2026 that may be closed by this pull request
Misskey lacks resource ownership validation #498847
Closed
@Prince213 Prince213 mentioned this pull request Jun 10, 2026
Closed
@Prince213 Prince213 linked an issue Jun 10, 2026 that may be closed by this pull request
Misskey lacks proper authorization checks and input validation #498849
Closed
@Prince213 Prince213 mentioned this pull request Jun 10, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imincik imincik imincik approved these changes

@eljamm eljamm Awaiting requested review from eljamm

@ethancedwards8 ethancedwards8 Awaiting requested review from ethancedwards8

@Prince213 Prince213 Awaiting requested review from Prince213

@wegank wegank Awaiting requested review from wegank

+1 more reviewer

@phanirithvij phanirithvij phanirithvij approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: package (update) This PR updates a package to a newer version 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-26.05 Backport PR automatically

Projects

None yet

Milestone

No milestone

4 participants

@Vonfry @imincik @phanirithvij @eljamm