testers.lycheeLinkCheck: improve root-relative link UX#520792
Merged
Conversation
95cf52a to
bbbe5b5
Compare
Lychee by itself does not have a way to explicitly declare the intent for the site to be relocatable. Recent-ish changes in lychee and/or its dependencies have made it catch the a root reference in all mdbook 404.html pages, which is quite confusing. By improving the UX around this aspect of the site, we resolve at least part of that confusion. (Though mdbook users should probably exclude the 404 page)
bbbe5b5 to
fb0d18e
Compare
Contributor
|
philiptaron
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lychee by itself does not have a way to explicitly declare the intent for the site to be relocatable.
Recent-ish changes in lychee and/or its dependencies have made it catch the a root reference in all mdbook 404.html pages, which is quite confusing.
By improving the UX around this aspect of the site, we resolve at least part of that confusion.
(Though mdbook users should probably exclude the 404 page)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.