Skip to content

snyk: remove nodejs version pin#518072

Merged
gepbird merged 1 commit into
NixOS:masterfrom
epireyn:update/snyk-nodejs
May 14, 2026
Merged

snyk: remove nodejs version pin#518072
gepbird merged 1 commit into
NixOS:masterfrom
epireyn:update/snyk-nodejs

Conversation

@epireyn

@epireyn epireyn commented May 8, 2026

Copy link
Copy Markdown
Contributor

See #515284.

I did not update the package because of build errors. We should wait on upstream to update their dependencies. It may also be needed to pin nodejs again after upstream update.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested a review from momeemt May 8, 2026 14:21
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 8, 2026
See NixOS#515284.

I did not update the package because of build errors. We should wait on upstream to update their dependencies. It may also be needed to pin nodejs again after upstream update.
@epireyn epireyn force-pushed the update/snyk-nodejs branch from d48d1c5 to e8ede59 Compare May 8, 2026 14:26
@epireyn

epireyn commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 518072
Commit: e8ede596c884f504d94996f2e9dcf514372969e8


x86_64-linux

✅ 1 package built:
  • snyk

@qweered qweered mentioned this pull request May 8, 2026
25 tasks
@gepbird gepbird added this pull request to the merge queue May 14, 2026
Merged via the queue into NixOS:master with commit 80d6af3 May 14, 2026
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants