scanservjs: use generic nodejs version#518019
Merged
Merged
Conversation
Upstream seems to stick to old versions for development (nodejs 16 for UI development), breaking changes with latest nodejs should therefore be pretty unlikely (for now). Resolves NixOS#515284
Contributor
Author
|
Member
I would say the opposite. New versions might remove deprecated features. We should probably just bump to 24 and hope for the best. |
Contributor
Author
|
That's exactly what I did :). |
qweered
approved these changes
May 9, 2026
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.11
git worktree add -d .worktree/backport-518019-to-release-25.11 origin/release-25.11
cd .worktree/backport-518019-to-release-25.11
git switch --create backport-518019-to-release-25.11
git cherry-pick -x b5edec9e119fcd00c708abecae0243313945130f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream seems to stick to old versions for development (nodejs 16 for UI development), breaking changes with latest nodejs should therefore be pretty unlikely (for now).
See #515284
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.