Skip to content

send: use nodejs_22#515607

Merged
pyrox0 merged 1 commit into
NixOS:masterfrom
Moraxyc:fix-send-nodejs22
May 4, 2026
Merged

send: use nodejs_22#515607
pyrox0 merged 1 commit into
NixOS:masterfrom
Moraxyc:fix-send-nodejs22

Conversation

@Moraxyc

@Moraxyc Moraxyc commented May 1, 2026

Copy link
Copy Markdown
Member

nodejs_20 is EOL

#515284

dannycoates-express-ws-drop-esm-loader.patch is to replace the outdated esm runtime loader in @dannycoates/express-ws so it works with nodejs_22.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested a review from MrSom3body May 1, 2026 20:38
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 1, 2026
@qweered qweered mentioned this pull request May 1, 2026
Open
25 tasks
MrSom3body
MrSom3body approved these changes May 2, 2026
View reviewed changes

@MrSom3body MrSom3body left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 2, 2026
@pyrox0 pyrox0 added this pull request to the merge queue May 4, 2026
@pyrox0 pyrox0 added the backport release-25.11 Backport PR automatically label May 4, 2026
Merged via the queue into NixOS:master with commit 1123178 May 4, 2026
38 of 40 checks passed
@nixpkgs-ci

nixpkgs-ci Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.11
git worktree add -d .worktree/backport-515607-to-release-25.11 origin/release-25.11
cd .worktree/backport-515607-to-release-25.11
git switch --create backport-515607-to-release-25.11
git cherry-pick -x ff4cd7e1d7364812ef29bf1ce0f20b561a78177c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MrSom3body MrSom3body MrSom3body approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Moraxyc @MrSom3body @pyrox0