Skip to content

tandoor-recipes: use nodejs_22 for frontend#515361

Merged
pyrox0 merged 1 commit into
NixOS:masterfrom
ryand56:tandoor-recipes/nodejs_22
May 2, 2026
Merged

tandoor-recipes: use nodejs_22 for frontend#515361
pyrox0 merged 1 commit into
NixOS:masterfrom
ryand56:tandoor-recipes/nodejs_22

Conversation

@ryand56

@ryand56 ryand56 commented May 1, 2026

Copy link
Copy Markdown
Member

Related: #515284
Upstream uses Node.js 22 in CI. https://github.com/TandoorRecipes/recipes/blob/2.6.9/.github/workflows/ci.yml#L13

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Upstream uses Node.js 22 in CI.
@nixpkgs-ci nixpkgs-ci Bot requested a review from jvanbruegge May 1, 2026 10:05
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 1, 2026
@ryand56 ryand56 added the backport release-25.11 Backport PR automatically label May 1, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 1, 2026
@qweered qweered mentioned this pull request May 1, 2026
25 tasks
@pyrox0

pyrox0 commented May 2, 2026

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 515361 --package tandoor-recipes.passthru.tests
Commit: 4f586a19d1f6eb2e1e82df384c0138a10cfab293


x86_64-linux

✅ 3 packages built:
  • tandoor-recipes.passthru.tests.tandoor-recipes
  • tandoor-recipes.passthru.tests.tandoor-recipes-media
  • tandoor-recipes.passthru.tests.tandoor-recipes-script-name

@pyrox0 pyrox0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@pyrox0 pyrox0 added this pull request to the merge queue May 2, 2026
Merged via the queue into NixOS:master with commit ab15b5d May 2, 2026
38 of 41 checks passed
@nixpkgs-ci

nixpkgs-ci Bot commented May 2, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-25.11:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 2, 2026
@ryand56 ryand56 deleted the tandoor-recipes/nodejs_22 branch May 2, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants