slskd: nodejs_20 EOL -> nodejs_24#515341
Conversation
|
|
The upstream Dockerfile uses nodejs_22, maybe we can be conservative and use that major version too instead? |
As you wish, I based myself on the requirements needing at least version 18 and took the latest working version available to avoid more work in the near future. But we can follow upstream if you feel more like it |
|
You're right, if it works, that's probably fine. Thanks! |
|
Would it be possible to unpin the version?(so just using |
|
It is, but I've always been told it is better to pin versions in packages? I'd like to better grasp the use of pinned version then :) |
I'd only pin a version if it will break without a specific pinned version(because we would rather as many packages as possible use the latest version of dependencies for security and maintainability reasons), has this package broken with non-pinned nodeJS versions before? |
|
I wouldn't know, it's the first time I've updated it. I just based myself on its explicit use of version 20, and changed that. I will unpin it and see, unless other reviewers are against it |
|
I would prefer to track upstream if we have a pinned version- minimizing differences from their setup reduces troubleshooting work I think. |
Sounds good to me. |
|
pyrox0
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
|
Successfully created backport PR for |
Bumps nodejs version from 20 to 24.
See #515284 for reference (announces nodejs 20 EOL).
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.