jellyfin-web: nodejs_20 EOL -> nodejs_22#515337
Conversation
See NixOS#515284 for reference.
|
purcell
left a comment
There was a problem hiding this comment.
Happy with this in principle, but plain nodejs is likely fine here.
| }; | ||
|
|
||
| nodejs = nodejs_20; # does not build with 22 | ||
| nodejs = nodejs_22; |
There was a problem hiding this comment.
Upstream is on Node 24 — should we use that one instead, or perhaps even better, just the default version, rather than being conservative here?
There was a problem hiding this comment.
Oddly enough, it does not build with the NodeJS 24 packaged here, since it comes with npm 11.11.0 and upstream expects npm <= 11.0.0 (iirc)
There was a problem hiding this comment.
Upstream is on Node 24
This commit isn't in a packaged release yet, so I don't think it applies here yet. Once a release with that commit in it makes it to a stable release, then a nodejs_22 -> nodejs_24 bump should work
|
pyrox0
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
|
Successfully created backport PR for |
Bump nodejs version from 20 to 22
See #515284 for reference (announces EOL of nodejs 20)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.