Skip to content

cdrdao: fix missing iconv on Darwin#511591

Merged
vcunat merged 1 commit into
NixOS:staging-nextfrom
sarahec:fix-cdrdao
Apr 22, 2026
Merged

cdrdao: fix missing iconv on Darwin#511591
vcunat merged 1 commit into
NixOS:staging-nextfrom
sarahec:fix-cdrdao

Conversation

@sarahec

@sarahec sarahec commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Hydra: 326322955

Build fails on Darwin with "__iconv undefined".
Set env.am_cv_func_iconv_works = "yes" so it uses the existing library.

Tracking: #511329

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Apr 19, 2026
@sarahec

sarahec commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 511591
Commit: 40b8886dcd923d8ec54eea3f49bf716b96a1fe11


x86_64-linux

✅ 8 packages built:
  • cdrdao
  • kdePackages.k3b
  • kdePackages.k3b.debug
  • kdePackages.k3b.dev
  • kdePackages.k3b.devtools
  • whipper
  • whipper.dist
  • whipper.man

@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label Apr 20, 2026
@vcunat vcunat added this pull request to the merge queue Apr 22, 2026
Merged via the queue into NixOS:staging-next with commit 72f9652 Apr 22, 2026
29 of 31 checks passed
@sarahec sarahec deleted the fix-cdrdao branch April 22, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants