nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 509708 --additional-package nixosTests.ente
Commit: ede42c75f752e1a4f43084881633e22a1a86c641

x86_64-linux

Not so sure about documenting quite a lot of garage specifics inside ente docs. Seems like something that should probably be just a link to either some nixos garage docs or some wiki.

I agree, it's generally more to set up with garage. But admittedly, I am struggling a bit to remove information without making the guide hard to follow. Any pointers on what you would like to omit?

In general: i don't think the md is reachable in any other way then then the GitHub Code Browser? So maybe this whole thing would be better served with beeing inside wiki.nixos.org? 🙈

Good point! Seems like I forgot to include the meta attribute on the module a while back 😅 I added that in now.

I would just keep it at something along the lines of "you need an S3 compatible object storage. You can self host that with software like Garage (here is a link with instructions on how to set that up).

And then put the garage specifics into https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/web-servers/garage.md or the like.

And then continue with now you've got a hostname, bucket name, access key and secret key. Put them into these places.

That way it's also easy to follow when you don't want to use garage because you make the split exactly where both of those services meet in a standardized way.