retroshare: fix build with gcc 14 and newer cmake#507625
Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom Apr 7, 2026
Merged
retroshare: fix build with gcc 14 and newer cmake#507625Sigmanificient merged 2 commits intoNixOS:masterfrom
Sigmanificient merged 2 commits intoNixOS:masterfrom
Conversation
d365134 to
256cdc7
Compare
17 tasks
Member
Sigmanificient
left a comment
There was a problem hiding this comment.
Please attempt to bump it to 3.10 instead of the minimal supported version. See #445447
Stekke
approved these changes
Apr 7, 2026
Contributor
Stekke
left a comment
There was a problem hiding this comment.
Tested, and working here, thanks!
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
17af3bd to
b886689
Compare
Sigmanificient
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507584
Cause
Starting with GCC 14, the C compiler implicitly defaults to
-std=c23, makingboola reserved language keyword. Theopenpgpsdksubmodule inretrosharehistorically usedboolas a variable name, which triggered build failures duringpacket-print.candpacket-parse.ccompilation.Furthermore, once past the GCC 14 issues, the build failed configuring the
udp-discovery-cppsubmodule because itsCMakeLists.txtstrictly requested CMake2.8. Modern CMake in Nixpkgs dropped compatibility for< 3.5, resulting in configuration failures.Changes
boolvariables in openpgpsdk tobool_valto resolveGCC 14 / C23 keyword compilation errors (Fixes Build failure: retroshare #507584)
2.8 to 3.5 to fix configuration errors with newer CMake versions
Things done
Built on platform:
Tested, as applicable:
ran
nix-build -A retrosharewhich builds successfully on NixOS 26.05.Tested basic functionality of binary in
./result/bin/Maintainer ping for review/testing: @Stekke