nixos/tests: disable nixosTests.nixos-test-driver.containers for now#503014
nixos/tests: disable nixosTests.nixos-test-driver.containers for now#503014jfly wants to merge 1 commit into
nixosTests.nixos-test-driver.containers for now#503014Conversation
We're unsure about exposing `/dev/net` in the build sandbox. Until we figure that out (tracked by NixOS/infra#987), let's just disable the test that requires `/dev/net` (note: this is not a strict requirement for tests that use test containers, it only applies to tests that test networking between test containers and qemu vms).
| containers = runTest ./nixos-test-driver/containers.nix; | ||
| # Disabled until we figure out if we want to expose `/dev/net` in the build | ||
| # sandbox on Hydra. See <https://github.com/NixOS/infra/issues/987>. | ||
| # containers = runTest ./nixos-test-driver/containers.nix; |
There was a problem hiding this comment.
Can't we disable it with meta.hydraPlatforms = [];? While Hydra shouldn't build it, I'd very much like to keep it "accessible" in-tree.
There was a problem hiding this comment.
I don't know. This doesn't seem to affect the behavior of import nixos/release-combined.nix {} at all. Is this meta.hydraPlatforms something that hydra itself looks at somewhere?
There was a problem hiding this comment.
OK that's really odd: nixos tests accept a meta.hydraPlatforms, but it's flat-out ignored 🙃
Feel free to ship it then as immediate fix.
I may look into fixing this properly. I feel like we should set hydraPlatforms for all of these tests until we are in a state where these can be run on h.n.o.
|
Can this pull request be closed as #503721 was merged instead? As the pull request disables the test that includes /dev/net in hydra. |
|
Yes, thanks for the ping! |
We're unsure about exposing
/dev/netin the build sandbox. Until we figure that out (tracked by NixOS/infra#987), let's just disable the test that requires/dev/net(note: this is not a strict requirement for tests that use test containers, it only applies to tests that test networking between test containers and qemu vms).Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.