Skip to content

pvsneslib: fix build#502877

Merged
mdaniels5757 merged 1 commit intoNixOS:masterfrom
Sigmanificient:pvsneslib
Apr 5, 2026
Merged

pvsneslib: fix build#502877
mdaniels5757 merged 1 commit intoNixOS:masterfrom
Sigmanificient:pvsneslib

Conversation

@Sigmanificient
Copy link
Copy Markdown
Member

@Sigmanificient Sigmanificient commented Mar 24, 2026 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@Sigmanificient Sigmanificient mentioned this pull request Mar 24, 2026
Open
17 tasks
@nixpkgs-ci nixpkgs-ci bot requested a review from soyouzpanda March 24, 2026 00:36
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Mar 24, 2026
@mdaniels5757
Copy link
Copy Markdown
Member

mdaniels5757 commented Mar 24, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 502877
Commit: 81d08b43d36e0abb6f46f62837a344800c6384c6 (subsequent changes)
Merge: 23238634011dc43174fff3eea8dbc4cc21a09ffe

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/23467550510

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-502877-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
  ' \
  /nix/store/06yg2ghgwjg0as1nqx4bg8c3m9rsqgrr-pvsneslib-4.2.0
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-502877-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
  ' \
  /nix/store/rqj7w59rrymwchwr74jffva1azpw5nwb-pvsneslib-4.2.0
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-502877-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
  ' \
  /nix/store/m3zhv926pgz9f52mif4cnm9q48xr5gxx-pvsneslib-4.2.0

x86_64-linux

✅ 1 package built:
  • pvsneslib

aarch64-linux

✅ 1 package built:
  • pvsneslib

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • pvsneslib

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • pvsneslib
Error logs: `aarch64-darwin`
pvsneslib 
Binary  directory   /usr/local/bin
TinyCC directory    /usr/local/lib/tcc
Library directory   /usr/local/lib
Include directory   /usr/local/include
Manual directory    /usr/local/man
Doc directory       /usr/local/share/doc/tcc
Target root prefix  
Source path      /nix/build/nix-42471-1850277103/source/compiler/tcc
C compiler       gcc
CPU              arm64
Big Endian       no
gprof enabled    no
cross compilers  no
use libgcc       no
Creating config.mak and config.h
config.mak:2: *** missing separator.  Stop.
make[2]: Leaving directory '/nix/build/nix-42471-1850277103/source/compiler/tcc'
make[1]: *** [Makefile:50: tcc-clean] Error 2
make[1]: Leaving directory '/nix/build/nix-42471-1850277103/source/compiler'
make: *** [Makefile:51: clean] Error 2

@Sigmanificient
Copy link
Copy Markdown
Member Author

Sigmanificient commented Mar 24, 2026

What's happening here 🤔

@mdaniels5757
Copy link
Copy Markdown
Member

mdaniels5757 commented Mar 24, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 502877
Commit: 81d08b43d36e0abb6f46f62837a344800c6384c6

aarch64-darwin

✅ 1 package built:
  • pvsneslib

mdaniels5757
mdaniels5757 approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like either a fluke or GitHub Actions weirdness.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 24, 2026
@mdaniels5757 mdaniels5757 added this pull request to the merge queue Apr 5, 2026
Merged via the queue into NixOS:master with commit 97064f4 Apr 5, 2026
36 of 38 checks passed
@Sigmanificient Sigmanificient deleted the pvsneslib branch April 5, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@soyouzpanda soyouzpanda Awaiting requested review from soyouzpanda

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sigmanificient @mdaniels5757