Skip to content

keyleds: fix build#502864

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
Sigmanificient:keyleds
Mar 24, 2026
Merged

keyleds: fix build#502864
GaetanLepage merged 1 commit intoNixOS:masterfrom
Sigmanificient:keyleds

Conversation

@Sigmanificient
Copy link
Copy Markdown
Member

@Sigmanificient Sigmanificient commented Mar 23, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@Sigmanificient Sigmanificient mentioned this pull request Mar 23, 2026
Open
17 tasks
@nixpkgs-ci nixpkgs-ci bot requested a review from GaetanLepage March 24, 2026 00:03
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Mar 24, 2026
@mdaniels5757
Copy link
Copy Markdown
Member

mdaniels5757 commented Mar 24, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 502864
Commit: fb65fb6be673bf0a906615bf13af37a7d5aafbda (subsequent changes)
Merge: 35f13743a67ae8971f95322a0ae1de57fc2c3873

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/23467477465

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-502864-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
  ' \
  /nix/store/qx20l3ksxhs7g6irfd4hbk9v1q8dwbwp-keyleds-unstable-2021-04-08
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-502864-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
  ' \
  /nix/store/82wrjcacnm4brlqmvwfsyi27yrcps6dg-keyleds-unstable-2021-04-08

x86_64-linux

✅ 1 package built:
  • keyleds

aarch64-linux

✅ 1 package built:
  • keyleds

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

mdaniels5757
mdaniels5757 approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 24, 2026
GaetanLepage
GaetanLepage approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage GaetanLepage added this pull request to the merge queue Mar 24, 2026
Merged via the queue into NixOS:master with commit cff34e3 Mar 24, 2026
35 of 37 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 24, 2026
@Sigmanificient Sigmanificient deleted the keyleds branch March 24, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigmanificient @mdaniels5757 @GaetanLepage