Skip to content

netifd: unstable-2023-11-27 -> 0-unstable-2026-02-26#501833

Merged
mdaniels5757 merged 1 commit intoNixOS:masterfrom
wishstudio:update-netifd
Mar 26, 2026
Merged

netifd: unstable-2023-11-27 -> 0-unstable-2026-02-26#501833
mdaniels5757 merged 1 commit intoNixOS:masterfrom
wishstudio:update-netifd

Conversation

@wishstudio
Copy link
Copy Markdown
Contributor

@wishstudio wishstudio commented Mar 21, 2026

Updated to latest HEAD to fix cmake 4 compilation problem.

Per OpenWrt's package Makefile this should link to their libnl-tiny fork. It contains some debug functions called by netifd such as nl_socket_set_tx_debug_cb and nl_socket_set_rx_debug_cb which isn't in upstream libnl.

The maybe-uninitialized error seems to not trigger with current gcc, thus also removed the CFLAGS.

Ref #445447
Ref #452993

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from mkg20001 March 21, 2026 03:18
@nixpkgs-ci nixpkgs-ci bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 21, 2026
@Sigmanificient Sigmanificient mentioned this pull request Mar 23, 2026
Open
17 tasks
mdaniels5757
mdaniels5757 reviewed Mar 24, 2026
View reviewed changes
@wishstudio wishstudio changed the title netifd: unstable-2023-11-27 -> unstable-2026-02-26 netifd: unstable-2023-11-27 -> 0-unstable-2026-02-26 Mar 25, 2026
@mdaniels5757
Copy link
Copy Markdown
Member

mdaniels5757 commented Mar 26, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 501833
Commit: 9c031c582bbd7064f23650deb8f02bf8a84e6221 (subsequent changes)
Merge: f6228dd17c8b2dd1f2e3ff7b5729be6d04552515

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/23620776661

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-501833-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
  ' \
  /nix/store/kd7mazsicixnpyp6lv14hdkz9ljn0ra3-netifd-0-unstable-2026-02-26
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-501833-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
  ' \
  /nix/store/n9x921cxnaryak9gj8z7pcm29mswrw4h-netifd-0-unstable-2026-02-26

x86_64-linux

✅ 1 package built:
  • netifd

aarch64-linux

✅ 1 package built:
  • netifd

mdaniels5757
mdaniels5757 approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@mdaniels5757 mdaniels5757 enabled auto-merge March 26, 2026 22:19
@mdaniels5757 mdaniels5757 added this pull request to the merge queue Mar 26, 2026
Merged via the queue into NixOS:master with commit 9dd03f7 Mar 26, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@mkg20001 mkg20001 Awaiting requested review from mkg20001

Assignees

No one assigned

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wishstudio @mdaniels5757