home-assistant: pin python-roborock to 4.15.0 for 2026.2.x compatibility#500419
Closed
Olauge-Secret wants to merge 1 commit into
Closed
home-assistant: pin python-roborock to 4.15.0 for 2026.2.x compatibility#500419Olauge-Secret wants to merge 1 commit into
Olauge-Secret wants to merge 1 commit into
Conversation
python-roborock >= 4.16.0 introduced breaking API changes (fan_power_options renamed to fan_speed_options) that require home-assistant >= 2026.3.0. Since home-assistant is currently at 2026.2.3, pin python-roborock to 4.15.0 which is the last compatible version. Also pins pyrate-limiter to 3.9.0 for this override, as python-roborock 4.15.0 requires pyrate-limiter >= 3.7.0, < 4. Resolves NixOS#500395
Member
| tag = "v${version}"; | ||
| hash = "sha256-M1LAAQRzJkVQKHin/SUEEVVgFKFCbYbZ2NZ8vSwT+1Y="; | ||
| }; | ||
| dependencies = (lib.filter (dep: (dep.pname or "") != "pyrate-limiter") (oldAttrs.dependencies or [ ])) ++ [ |
Member
There was a problem hiding this comment.
We do not do such filters on dependencies. It should be on the same level as python-roborock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #500395
python-roborockwas updated to 4.17.1 in #495067, which introduced breaking API changes (fan_power_optionsrenamed tofan_speed_options). This causes the roborock vacuum component in home-assistant 2026.2.3 to crash with:The fix in upstream home-assistant is in 2026.3.0, but nixpkgs currently ships 2026.2.3.
Changes
python-roborockto 4.15.0 (last version compatible with home-assistant 2026.2.x) in the home-assistant package overridespyrate-limiterto 3.9.0 for this override, sincepython-roborock4.15.0 requirespyrate-limiter >=3.7.0,<4while nixpkgs ships 4.0.2This override can be removed once home-assistant is updated to 2026.3.x.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.cc @fabaff