Skip to content

python3Packages.moto: reduce test dependencies#496457

Merged
mweinelt merged 1 commit into
NixOS:stagingfrom
dotlambda:python3Packages.moto
Mar 4, 2026
Merged

python3Packages.moto: reduce test dependencies#496457
mweinelt merged 1 commit into
NixOS:stagingfrom
dotlambda:python3Packages.moto

Conversation

@dotlambda

@dotlambda dotlambda commented Mar 4, 2026

Copy link
Copy Markdown
Member

The sagemaker package is outdated and doesn't work on Python 3.14.
related: #496451

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@dotlambda dotlambda changed the base branch from master to staging March 4, 2026 02:50
@nixpkgs-ci nixpkgs-ci Bot closed this Mar 4, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Mar 4, 2026
@dotlambda dotlambda force-pushed the python3Packages.moto branch from 2c46583 to 5eefba5 Compare March 4, 2026 02:54
@dotlambda dotlambda changed the title python3Packages.moto: don't depend on sagemaker python3Packages.moto: reduce test dependencies Mar 4, 2026
@dotlambda
python3Packages.moto: reduce test dependencies
451acdf 
The sagemaker and cfn-lint packages don't work on Python 3.14. Removing
them from `nativeCheckInputs` lets us build moto for Python 3.14.
@dotlambda dotlambda requested a review from onny March 4, 2026 02:57
@dotlambda dotlambda force-pushed the python3Packages.moto branch from 5eefba5 to 451acdf Compare March 4, 2026 02:57
@dotlambda dotlambda mentioned this pull request Mar 4, 2026
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Mar 4, 2026
@dotlambda dotlambda requested a review from mweinelt March 4, 2026 03:26
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 4, 2026
@mweinelt mweinelt added this pull request to the merge queue Mar 4, 2026
Merged via the queue into NixOS:staging with commit 2fc3717 Mar 4, 2026
35 of 37 checks passed
@dotlambda dotlambda deleted the python3Packages.moto branch March 4, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@onny onny Awaiting requested review from onny

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dotlambda @mweinelt