Skip to content

various: migrate fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 (part 1)#494404

Merged
gepbird merged 17 commits into
NixOS:masterfrom
qweered:fetcherVersion-3-migration-part1
Feb 28, 2026
Merged

various: migrate fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 (part 1)#494404
gepbird merged 17 commits into
NixOS:masterfrom
qweered:fetcherVersion-3-migration-part1

Conversation

@qweered

@qweered qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Migrate various packages using fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 and update their hashes accordingly.

fetcherVersion = 1 is deprecated and will be removed. Version 3 uses a more robust fetching strategy.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@qweered qweered marked this pull request as ready for review February 26, 2026 15:20
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 26, 2026
@qweered qweered force-pushed the fetcherVersion-3-migration-part1 branch from b231baf to b46d5f4 Compare February 26, 2026 17:21
@qweered qweered requested a review from gepbird February 26, 2026 17:59
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Feb 26, 2026
@qweered

qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 494404 --skip-package signal-desktop
Commit: 33967862a5847900e9780de51a44f2d33f594b84


x86_64-linux

✅ 16 packages built:
  • aonsoku
  • apache-airflow
  • apache-airflow.dist
  • apache-answer
  • artalk
  • authelia
  • autoprefixer
  • backrest
  • clash-verge-rev
  • daed
  • dorion
  • emmet-language-server
  • equicord
  • etherpad-lite
  • fedistar
  • lemmy-ui

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 26, 2026
@qweered qweered force-pushed the fetcherVersion-3-migration-part1 branch from 3396786 to 9f66ecf Compare February 26, 2026 19:30
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 26, 2026

@gepbird gepbird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Diff looks good for the fetcherVersion bumps. Can you please split the build fixes into other PRs? Maybe their maintainers have some comments, I don't want to block this by waiting on them.

@qweered qweered force-pushed the fetcherVersion-3-migration-part1 branch from 9f66ecf to 4a8caef Compare February 26, 2026 22:41
@qweered

qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

Done, clash-verge-rev fail actually introduced by this pr somehow, i leave note regarding that in splitted pr

@qweered qweered requested a review from gepbird February 26, 2026 22:46
@gepbird

gepbird commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

No new failures.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 494404
Commit: 4a8caef882d9a23bb5a6dddc0f15d9004b1ce657


x86_64-linux

❌ 2 packages failed to build:
  • apache-airflow
  • apache-airflow.dist
✅ 15 packages built:
  • aonsoku
  • apache-answer
  • artalk
  • authelia
  • autoprefixer
  • backrest
  • clash-verge-rev
  • daed
  • dorion
  • emmet-language-server
  • equicord
  • etherpad-lite
  • fedistar
  • lemmy-ui
  • signal-desktop

@gepbird gepbird added this pull request to the merge queue Feb 27, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 28, 2026
Merged via the queue into NixOS:master with commit a7c3d71 Feb 28, 2026
29 checks passed
@qweered qweered deleted the fetcherVersion-3-migration-part1 branch April 24, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants