Skip to content

various: migrate fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 (part 3)#494401

Merged
gepbird merged 15 commits into
NixOS:masterfrom
qweered:fetcherVersion-3-migration-part3
Mar 2, 2026
Merged

various: migrate fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 (part 3)#494401
gepbird merged 15 commits into
NixOS:masterfrom
qweered:fetcherVersion-3-migration-part3

Conversation

@qweered

@qweered qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Migrate various packages using fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 and update their hashes accordingly.

fetcherVersion = 1 is deprecated and will be removed. Version 3 uses a more robust fetching strategy.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@qweered qweered marked this pull request as ready for review February 26, 2026 15:20
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 26, 2026
@qweered

qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 494401
Commit: 22a1ffb504cc9116221ef4ea842e19cc1f6c24fb (subsequent changes)
Merge: d8215d38f0fcc4201b1234f2169ba6a61c828bc6

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/22453315164


x86_64-linux

❌ 2 packages failed to build:
  • documenso
  • quantframe
✅ 18 packages built:
  • ghostfolio
  • linkwarden
  • overlayed
  • parca
  • pgrok
  • pgrok.server
  • piped
  • porn-vault
  • prisma_6
  • rmfakecloud
  • rquickshare
  • rsshub
  • siyuan
  • slimevr
  • stylelint-lsp
  • synchrony
  • syncyomi
  • tabby-agent

Error logs: `x86_64-linux`
documenso
Validating consistency between /build/source/package-lock.json and /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps/package-lock.json
Setting npm_config_cache to /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps
Installing dependencies
npm warn Unknown env config "nodedir". This will stop working in the next major version of npm.
npm warn Unknown env config "platform". This will stop working in the next major version of npm.
npm warn Unknown env config "arch". This will stop working in the next major version of npm.
npm warn Unknown project config "auto-install-peers". This will stop working in the next major version of npm.
npm error code ENOTCACHED
npm error request to https://registry.npmjs.org/ajv failed: cache mode is 'only-if-cached' but no cached response is available.
npm error Log files were not written due to an error writing to the directory: /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

ERROR: npm failed to install dependencies

Here are a few things you can try, depending on the error:

  1. Set npmDepsFetcherVersion = 2 (and update npmDepsHash)
  2. Set makeCacheWritable = true
    Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
  3. Set npmFlags = [ "--legacy-peer-deps" ]
quantframe
node_modules/.pnpm/node_modules/.bin/jsesc: interpreter directive changed from "#!/bin/sh" to "/nix/store/2hjsch59amjs3nbgh7ahcfzm2bfwl8zi-bash-5.3p9/bin/sh"
node_modules/.pnpm/node_modules/.bin/node-which: interpreter directive changed from "#!/bin/sh" to "/nix/store/2hjsch59amjs3nbgh7ahcfzm2bfwl8zi-bash-5.3p9/bin/sh"
node_modules/.pnpm/node_modules/.bin/acorn: interpreter directive changed from "#!/bin/sh" to "/nix/store/2hjsch59amjs3nbgh7ahcfzm2bfwl8zi-bash-5.3p9/bin/sh"
node_modules/.pnpm/node_modules/.bin/cssesc: interpreter directive changed from "#!/bin/sh" to "/nix/store/2hjsch59amjs3nbgh7ahcfzm2bfwl8zi-bash-5.3p9/bin/sh"
node_modules/.pnpm/node_modules/.bin/update-browserslist-db: interpreter directive changed from "#!/bin/sh" to "/nix/store/2hjsch59amjs3nbgh7ahcfzm2bfwl8zi-bash-5.3p9/bin/sh"
node_modules/.pnpm/node_modules/.bin/rimraf: interpreter directive changed from "#!/bin/sh" to "/nix/store/2hjsch59amjs3nbgh7ahcfzm2bfwl8zi-bash-5.3p9/bin/sh"
node_modules/.pnpm/node_modules/.bin/browserslist: interpreter directive changed from "#!/bin/sh" to "/nix/store/2hjsch59amjs3nbgh7ahcfzm2bfwl8zi-bash-5.3p9/bin/sh"
Finished pnpmConfigHook
configurePhase completed in 56 seconds
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Executing tauriBuildHook
/build/source/src-tauri /build/source
cargo-tauri.hook cargoFlags: -j 4 --target x86_64-unknown-linux-gnu --offline --profile release
cargo-tauri.hook tauriFlags: --bundles deb --target x86_64-unknown-linux-gnu
        Info Looking up installed tauri packages to check mismatched versions...
       Error Found version mismatched Tauri packages. Make sure the NPM package and Rust crate versions are on the same major/minor releases:
tauri (v2.6.2) : @tauri-apps/api (v2.0.0)
tauri-plugin-http (v2.4.4) : @tauri-apps/plugin-http (v2.2.0)
tauri-plugin-fs (v2.3.0) : @tauri-apps/plugin-fs (v2.2.0)

@qweered qweered force-pushed the fetcherVersion-3-migration-part3 branch from 22a1ffb to f8f8951 Compare February 26, 2026 19:02
@qweered qweered requested a review from gepbird February 26, 2026 19:07
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Feb 26, 2026
@qweered

qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

Both failing packages have pending prs with fixes

@qweered

qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 494401
Commit: f8f8951af3c01c3ce746149480dbc5e5903a6bb7 (subsequent changes)
Merge: 6be5d683f4f197fddd4060bc540e5c01d9920e4f

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/22457062747


x86_64-linux

❌ 1 package failed to build:
  • documenso
✅ 18 packages built:
  • ghostfolio
  • linkwarden
  • overlayed
  • parca
  • pgrok
  • pgrok.server
  • piped
  • porn-vault
  • prisma_6
  • rmfakecloud
  • rquickshare
  • rsshub
  • siyuan
  • slimevr
  • stylelint-lsp
  • synchrony
  • syncyomi
  • tabby-agent

Error logs: `x86_64-linux`
documenso
Validating consistency between /build/source/package-lock.json and /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps/package-lock.json
Setting npm_config_cache to /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps
Installing dependencies
npm warn Unknown env config "nodedir". This will stop working in the next major version of npm.
npm warn Unknown env config "platform". This will stop working in the next major version of npm.
npm warn Unknown env config "arch". This will stop working in the next major version of npm.
npm warn Unknown project config "auto-install-peers". This will stop working in the next major version of npm.
npm error code ENOTCACHED
npm error request to https://registry.npmjs.org/ajv failed: cache mode is 'only-if-cached' but no cached response is available.
npm error Log files were not written due to an error writing to the directory: /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

ERROR: npm failed to install dependencies

Here are a few things you can try, depending on the error:

  1. Set npmDepsFetcherVersion = 2 (and update npmDepsHash)
  2. Set makeCacheWritable = true
    Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
  3. Set npmFlags = [ "--legacy-peer-deps" ]

@qweered

qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

Failure unrelated to fetchPnpmDeps change

@gepbird

gepbird commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

No new failures.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 494401
Commit: f8f8951af3c01c3ce746149480dbc5e5903a6bb7


x86_64-linux

❌ 1 package failed to build:
  • documenso
✅ 18 packages built:
  • ghostfolio
  • linkwarden
  • overlayed
  • parca
  • pgrok
  • pgrok.server
  • piped
  • porn-vault
  • prisma_6
  • rmfakecloud
  • rquickshare
  • rsshub
  • siyuan
  • slimevr
  • stylelint-lsp
  • synchrony
  • syncyomi
  • tabby-agent

Error logs: `x86_64-linux`
documenso
Validating consistency between /build/source/package-lock.json and /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps/package-lock.json
Setting npm_config_cache to /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps
Installing dependencies
npm warn Unknown env config "nodedir". This will stop working in the next major version of npm.
npm warn Unknown env config "platform". This will stop working in the next major version of npm.
npm warn Unknown env config "arch". This will stop working in the next major version of npm.
npm warn Unknown project config "auto-install-peers". This will stop working in the next major version of npm.
npm error code ENOTCACHED
npm error request to https://registry.npmjs.org/ajv failed: cache mode is 'only-if-cached' but no cached response is available.
npm error Log files were not written due to an error writing to the directory: /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

ERROR: npm failed to install dependencies

Here are a few things you can try, depending on the error:

  1. Set npmDepsFetcherVersion = 2 (and update npmDepsHash)
  2. Set makeCacheWritable = true
    Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
  3. Set npmFlags = [ "--legacy-peer-deps" ]

@gepbird gepbird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 28, 2026
@qweered qweered force-pushed the fetcherVersion-3-migration-part3 branch from f8f8951 to 89f5ef9 Compare March 2, 2026 00:05
@qweered

qweered commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Constantly confilcts on package updates, would appreciate faster merge 🥹

@qweered qweered requested review from NickCao and gepbird March 2, 2026 00:20
@qweered

qweered commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 494401
Commit: 89f5ef9e86c8eee6f39e4d4282f77b72c8c326a8 (subsequent changes)
Merge: e1f11fb220c5a4029b397391c62513e681766598

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/22556390394


x86_64-linux

❌ 1 package failed to build:
  • documenso
✅ 18 packages built:
  • ghostfolio
  • linkwarden
  • overlayed
  • parca
  • pgrok
  • pgrok.server
  • piped
  • porn-vault
  • prisma_6
  • rmfakecloud
  • rquickshare
  • rsshub
  • siyuan
  • slimevr
  • stylelint-lsp
  • synchrony
  • syncyomi
  • tabby-agent

Error logs: `x86_64-linux`
documenso
Validating consistency between /build/source/package-lock.json and /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps/package-lock.json
Setting npm_config_cache to /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps
Installing dependencies
npm warn Unknown env config "nodedir". This will stop working in the next major version of npm.
npm warn Unknown env config "platform". This will stop working in the next major version of npm.
npm warn Unknown env config "arch". This will stop working in the next major version of npm.
npm warn Unknown project config "auto-install-peers". This will stop working in the next major version of npm.
npm error code ENOTCACHED
npm error request to https://registry.npmjs.org/ajv failed: cache mode is 'only-if-cached' but no cached response is available.
npm error Log files were not written due to an error writing to the directory: /nix/store/m4d0hckndwadljinshlbzmbfcbz8xcmg-documenso-1.12.6-npm-deps/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

ERROR: npm failed to install dependencies

Here are a few things you can try, depending on the error:

  1. Set npmDepsFetcherVersion = 2 (and update npmDepsHash)
  2. Set makeCacheWritable = true
    Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
  3. Set npmFlags = [ "--legacy-peer-deps" ]

@gepbird gepbird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff still looks good.

@gepbird gepbird added this pull request to the merge queue Mar 2, 2026
Merged via the queue into NixOS:master with commit 6e971d3 Mar 2, 2026
27 checks passed
@gepbird

gepbird commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Constantly confilcts on package updates, would appreciate faster merge 🥹

Yea, merge conflicts are pain for treewides :(

I'm not sure how much should we wait for other potential reviewers (for pnpm fetcher version bump changes I could've merged instantly). After doing some hesitant, bad merges where people were complaining about their lack involvement, I try to give each PR a few days or at most a week.
Thanks for the feedback.

@qweered qweered deleted the fetcherVersion-3-migration-part3 branch April 24, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants