Skip to content

various: migrate fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 (part 2)#494400

Merged
gepbird merged 15 commits into
NixOS:masterfrom
qweered:fetcherVersion-3-migration-part2
Mar 2, 2026
Merged

various: migrate fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 (part 2)#494400
gepbird merged 15 commits into
NixOS:masterfrom
qweered:fetcherVersion-3-migration-part2

Conversation

@qweered

@qweered qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Migrate various packages using fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 and update their hashes accordingly.

fetcherVersion = 1 is deprecated and will be removed. Version 3 uses a more robust fetching strategy.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@qweered qweered marked this pull request as ready for review February 26, 2026 15:20
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 26, 2026
@qweered

qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 494400
Commit: 94af6f0fd6456f08bdbeae2c3cedd313d474ad9b (subsequent changes)
Merge: 9e6c2779577e15fc6a4da669473cabd37c9dfc2b

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/22453304466


x86_64-linux

❌ 6 packages failed to build:
  • froide
  • froide-govplan
  • froide-govplan.dist
  • froide.dist
  • modrinth-app
  • modrinth-app-unwrapped
✅ 15 packages built:
  • firezone-gui-client
  • firezone-server (firezone-server-domain)
  • firezone-server-api
  • firezone-server-web
  • folo
  • gale
  • goaway
  • goofcord
  • homebox
  • it-tools
  • jellyseerr
  • legcord
  • memos
  • metacubexd
  • moonfire-nvr

@qweered qweered marked this pull request as draft February 26, 2026 19:22
@nixpkgs-ci nixpkgs-ci Bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 26, 2026
@qweered

qweered commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

froide builds fine locally

nom-build -A froide -A froide-govplan
Finished at 02:32:04 after 10s
/nix/store/qcc6bdlwqqgvs2kvgmfdhllq8hnlqakb-froide-0-unstable-2025-09-10
/nix/store/ksvwayqiznww5yzjifhkh960bspxhf64-froide-govplan-0-unstable-2025-07-14

modrinth error unrelated

       > error[E0308]: mismatched types
       >   --> crates/turborepo-lib/src/commands/daemon.rs:70:30
       >    |
       > 70 |                 let client = connector.clone().connect().await?;
       >    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Result<_, DaemonError>`, found `Result<_, DaemonConnectorError>`
       >    |
       >    = note: expected enum `std::result::Result<_, DaemonError>`
       >               found enum `std::result::Result<_, DaemonConnectorError>`
       > help: use the `?` operator to extract the `std::result::Result<_, DaemonConnectorError>` value, propagating a `Result::Err` value to the caller
       >    |
       > 70 |                 let client = connector.clone().connect().await??;
       >    |                                                                +
       >
       > For more information about this error, try `rustc --explain E0308`.
       > error: could not compile `turborepo-lib` (lib) due to 1 previous error

@qweered qweered force-pushed the fetcherVersion-3-migration-part2 branch 2 times, most recently from c4d2d0b to d8596b4 Compare March 2, 2026 00:31
@qweered qweered marked this pull request as ready for review March 2, 2026 00:32
@qweered qweered requested a review from gepbird March 2, 2026 00:32
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 2, 2026
@qweered

qweered commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 494400
Commit: d8596b47ac42421410fdf8d993ebceadccc6c6bb (subsequent changes)
Merge: 9447c2673adec7e9935aefa98f68a1337c4fe3af

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/22556645205


x86_64-linux

✅ 20 packages built:
  • firezone-gui-client
  • firezone-server (firezone-server-domain)
  • firezone-server-api
  • firezone-server-web
  • folo
  • froide
  • froide-govplan
  • froide-govplan.dist
  • froide.dist
  • goaway
  • goofcord
  • homebox
  • it-tools
  • jellyseerr
  • legcord
  • memos
  • metacubexd
  • modrinth-app
  • modrinth-app-unwrapped
  • moonfire-nvr

@gepbird gepbird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you rebase one more time?

@qweered qweered force-pushed the fetcherVersion-3-migration-part2 branch from d8596b4 to 1ceef3a Compare March 2, 2026 11:16
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 2, 2026
@qweered

qweered commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 494400
Commit: 1ceef3aaede98d879f7bc40b540b6bff882e3ba0 (subsequent changes)
Merge: 25e87d7040e12b99680bc1c8a0e5eeb517e8ac19

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/22573542484


x86_64-linux

✅ 20 packages built:
  • firezone-gui-client
  • firezone-server (firezone-server-domain)
  • firezone-server-api
  • firezone-server-web
  • folo
  • froide
  • froide-govplan
  • froide-govplan.dist
  • froide.dist
  • goaway
  • goofcord
  • homebox
  • it-tools
  • jellyseerr
  • legcord
  • memos
  • metacubexd
  • modrinth-app
  • modrinth-app-unwrapped
  • moonfire-nvr

@qweered qweered requested a review from gepbird March 2, 2026 12:38
@gepbird gepbird added this pull request to the merge queue Mar 2, 2026
Merged via the queue into NixOS:master with commit ad91054 Mar 2, 2026
28 checks passed
@qweered qweered deleted the fetcherVersion-3-migration-part2 branch April 24, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants