regextester: 0.1.7 -> 1.0.1 by dtzWill · Pull Request #49431 · NixOS/nixpkgs

dtzWill · 2018-10-30T00:21:32Z

uses meson now
crashes on start complaining schema not installed,
so I added a postInstall that compiles the schema?
Fixes the problem but I'm not particularly familiar
with these bits so review appreciated.

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

* uses meson now * crashes on start complaining schema not installed, so I added a postInstall that compiles the schema? Fixes the problem but I'm not particularly familiar with these bits so review appreciated.

GrahamcOfBorg · 2018-10-30T00:33:08Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: regextester

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-30T00:35:59Z

Success on x86_64-linux (full log)

Attempted: regextester

Partial log (click to expand)

glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/izjpmsd4mn1nhkqr8aica10kzl4mz6k0-regextester-1.0.1/bin/com.github.artemanufrij.regextester
shrinking RPATHs of ELF executables and libraries in /nix/store/izjpmsd4mn1nhkqr8aica10kzl4mz6k0-regextester-1.0.1
shrinking /nix/store/izjpmsd4mn1nhkqr8aica10kzl4mz6k0-regextester-1.0.1/bin/.com.github.artemanufrij.regextester-wrapped
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/izjpmsd4mn1nhkqr8aica10kzl4mz6k0-regextester-1.0.1/bin
patching script interpreter paths in /nix/store/izjpmsd4mn1nhkqr8aica10kzl4mz6k0-regextester-1.0.1
checking for references to /build in /nix/store/izjpmsd4mn1nhkqr8aica10kzl4mz6k0-regextester-1.0.1...

GrahamcOfBorg · 2018-10-30T00:37:41Z

Success on aarch64-linux (full log)

Attempted: regextester

Partial log (click to expand)

glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/m49hkynamc5bcmxcr5h2bm0ijrb0dpys-regextester-1.0.1/bin/com.github.artemanufrij.regextester
shrinking RPATHs of ELF executables and libraries in /nix/store/m49hkynamc5bcmxcr5h2bm0ijrb0dpys-regextester-1.0.1
shrinking /nix/store/m49hkynamc5bcmxcr5h2bm0ijrb0dpys-regextester-1.0.1/bin/.com.github.artemanufrij.regextester-wrapped
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m49hkynamc5bcmxcr5h2bm0ijrb0dpys-regextester-1.0.1/bin
patching script interpreter paths in /nix/store/m49hkynamc5bcmxcr5h2bm0ijrb0dpys-regextester-1.0.1
checking for references to /build in /nix/store/m49hkynamc5bcmxcr5h2bm0ijrb0dpys-regextester-1.0.1...

jtojnar · 2018-10-30T05:21:32Z

pkgs/applications/misc/regextester/default.nix

    gtk3
    granite
+    gnome3.defaultIconTheme
+    gnome3.glib


Just use top-level glib.

worldofpeace · 2018-10-30T12:25:25Z

pkgs/applications/misc/regextester/default.nix

  ];
  buildInputs = [
-    gtk3
+    glib


gtk3 propagates glib and gsettings-desktop-schemas so adding is redundant

I prefer to be explicit and include every library that the project links with – the project can stop using gtk or gtk can stop propagating glib any time. (Well in the case of gtk – glib relationship, it pretty unlikely but I do not like making exceptions.)

I will keep that in mind in the future as well.

To be clear, I meant listing in buildInputs all the libraries declared as dependency in meson.build, not those dependencies that are only non-direct dependencies of the project. (Though projects sometimes forget to list some dependencies, relying on transitivity, which leads to breakages like #36468)

So just gtk3 would be appropriate because meson.build?

They definitely use glib so I would pin them to the second category.

worldofpeace · 2018-10-30T12:29:01Z

pkgs/applications/misc/regextester/default.nix

+    gobjectIntrospection
    libxml2
-    elementary-cmake-modules
+    vala


These apps should really use vala_0_40.

Maybe with a comment that it is supposed to be changed to elementary.vala once the elementary attribute set is merged.

GrahamcOfBorg · 2018-10-30T12:33:36Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: regextester

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

worldofpeace · 2018-10-30T12:33:49Z

pkgs/applications/misc/regextester/default.nix

  ];

+  postInstall = ''
+    ${gnome3.glib.dev}/bin/glib-compile-schemas $out/share/glib-2.0/schemas


gnome3.glib.dev -> glib.dev

Also usually a post install script like this does this.

That is something that is still not resolved in meson. Some projects prefer to leave this to downstream distro hooks, see Arch, for example.

GrahamcOfBorg · 2018-10-30T12:34:07Z

Success on x86_64-linux (full log)

Attempted: regextester

Partial log (click to expand)

glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1/bin/com.github.artemanufrij.regextester
shrinking RPATHs of ELF executables and libraries in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1
shrinking /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1/bin/.com.github.artemanufrij.regextester-wrapped
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1/bin
patching script interpreter paths in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1
checking for references to /build in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1...

dtzWill · 2018-10-30T12:54:51Z

Thank you for the feedback. I may not be able to get to this for a week or so (travel), feel free to make these changes or I'll do so when I get back. Apologies and thanks again :).

…

On Tue, 30 Oct 2018 12:34:13 +0000 (UTC), GrahamC of Borg ***@***.***> wrote:  Success on x86_64-linux [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.49431&attempt_id=b7373901-fe9a-4dcc-b5ff-ecf42ddd3fa9) Attempted: regextester <details><summary>Partial log (click to expand)</summary><p> ``` glibPreFixupPhase hicolorPreFixupPhase post-installation fixup Wrapping program /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1/bin/com.github.artemanufrij.regextester shrinking RPATHs of ELF executables and libraries in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1 shrinking /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1/bin/.com.github.artemanufrij.regextester-wrapped strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip stripping (with command strip and flags -S) in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1/bin patching script interpreter paths in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1 checking for references to /build in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1... ``` </p></details> -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #49431 (comment) part: text/html

GrahamcOfBorg · 2018-10-30T13:42:31Z

Success on aarch64-linux (full log)

Attempted: regextester

Partial log (click to expand)

glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/3valwys16njylxhav63ga293cdzlh7w9-regextester-1.0.1/bin/com.github.artemanufrij.regextester
shrinking RPATHs of ELF executables and libraries in /nix/store/3valwys16njylxhav63ga293cdzlh7w9-regextester-1.0.1
shrinking /nix/store/3valwys16njylxhav63ga293cdzlh7w9-regextester-1.0.1/bin/.com.github.artemanufrij.regextester-wrapped
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3valwys16njylxhav63ga293cdzlh7w9-regextester-1.0.1/bin
patching script interpreter paths in /nix/store/3valwys16njylxhav63ga293cdzlh7w9-regextester-1.0.1
checking for references to /build in /nix/store/3valwys16njylxhav63ga293cdzlh7w9-regextester-1.0.1...

worldofpeace · 2018-11-02T21:30:32Z

@dtzWill Finished this up for you in #49560 🎆

dtzWill · 2018-11-02T21:51:01Z

My hero! :swoon:

…

On Fri, 02 Nov 2018 14:30:37 -0700, worldofpeace ***@***.***> wrote: @dtzWill Finished this up for you in #49560 🎆 -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #49431 (comment) part: text/html

regextester: 0.1.7 -> 1.0.1

eca1547

* uses meson now * crashes on start complaining schema not installed, so I added a postInstall that compiles the schema? Fixes the problem but I'm not particularly familiar with these bits so review appreciated.

GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 30, 2018

jtojnar reviewed Oct 30, 2018

View reviewed changes

regextester: review feedback, just use top-level glib

7cbf1e7

worldofpeace reviewed Oct 30, 2018

View reviewed changes

worldofpeace mentioned this pull request Oct 31, 2018

update some elementary thirdparty apps #49560

Merged

9 tasks

jtojnar closed this Nov 3, 2018

Uh oh!

Conversation

dtzWill commented Oct 30, 2018

Uh oh!

GrahamcOfBorg commented Oct 30, 2018

Uh oh!

GrahamcOfBorg commented Oct 30, 2018

Uh oh!

GrahamcOfBorg commented Oct 30, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtojnar Oct 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GrahamcOfBorg commented Oct 30, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtojnar Oct 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GrahamcOfBorg commented Oct 30, 2018

Uh oh!

dtzWill commented Oct 30, 2018 via email

Uh oh!

GrahamcOfBorg commented Oct 30, 2018

Uh oh!

worldofpeace commented Nov 2, 2018

Uh oh!

dtzWill commented Nov 2, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jtojnar Oct 30, 2018 •

edited

Loading

jtojnar Oct 30, 2018 •

edited

Loading