Skip to content

nixos/athens: remove minio support#493931

Merged
katexochen merged 1 commit intoNixOS:masterfrom
katexochen:athens/minio
Feb 26, 2026
Merged

nixos/athens: remove minio support#493931
katexochen merged 1 commit intoNixOS:masterfrom
katexochen:athens/minio

Conversation

@katexochen
Copy link
Copy Markdown
Contributor

@katexochen katexochen commented Feb 25, 2026

#490996

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@katexochen katexochen mentioned this pull request Feb 25, 2026
Open
18 tasks
@katexochen katexochen requested a review from britter February 25, 2026 07:35
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 25, 2026
britter
britter approved these changes Feb 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@britter britter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth mentioning this as a breaking change in release notes?

@britter
Copy link
Copy Markdown
Contributor

britter commented Feb 25, 2026

Or maybe should there be a combined entry in release notes that covers all of the changes from #490996?

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 25, 2026
@katexochen
nixos/athens: remove minio support
5c6f18d 
NixOS#490996

Signed-off-by: Paul Meyer <katexochen0@gmail.com>
@katexochen
Copy link
Copy Markdown
Contributor Author

katexochen commented Feb 25, 2026

Is it worth mentioning this as a breaking change in release notes?

I've added mkRemovedOptionModule, which is required. Not sure it's worth putting this into the release notes, I think a combined note should be enough.

@britter
Copy link
Copy Markdown
Contributor

britter commented Feb 25, 2026

LGTM

@katexochen katexochen added this pull request to the merge queue Feb 26, 2026
Merged via the queue into NixOS:master with commit 459f477 Feb 26, 2026
28 of 30 checks passed
@katexochen katexochen deleted the athens/minio branch February 26, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@britter britter britter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@katexochen @britter