Skip to content

sharedown: switch to buildNpmPackage#493097

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/sharedown@rewrite
Feb 22, 2026
Merged

sharedown: switch to buildNpmPackage#493097
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/sharedown@rewrite

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

@doronbehar doronbehar commented Feb 22, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@doronbehar doronbehar force-pushed the pkg/sharedown@rewrite branch from c395555 to 3678cba Compare February 22, 2026 19:02
@doronbehar doronbehar mentioned this pull request Feb 22, 2026
Open
48 tasks
@doronbehar doronbehar requested a review from pyrox0 February 22, 2026 19:03
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 22, 2026
qweered
qweered suggested changes Feb 22, 2026
View reviewed changes
@qweered
Copy link
Copy Markdown
Contributor

qweered commented Feb 22, 2026

Lets also add nix-update-script, now it should be supported

@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Feb 22, 2026

Lets also add nix-update-script, now it should be supported

I usually don't add nix-update-scripts for trivial cases like this. Is it helpful to add it here since we want to track the latest git commit? If so, please tell me how.

@doronbehar doronbehar force-pushed the pkg/sharedown@rewrite branch from 3678cba to 6f61b11 Compare February 22, 2026 19:39
@qweered
Copy link
Copy Markdown
Contributor

qweered commented Feb 22, 2026 •
edited
Loading

Yes, it supports --version=branch to track latest commit while keeping main version point to latest tag, see https://wiki.nixos.org/wiki/Nixpkgs/Automatic_Updates

@doronbehar doronbehar mentioned this pull request Feb 22, 2026
Draft
2 tasks
@doronbehar
sharedown: switch to buildNpmPackage
ae7eb4a 
Addresses NixOS#324246. Update source version to include a package-lock.json
file, see:

kylon/Sharedown#128
@doronbehar doronbehar force-pushed the pkg/sharedown@rewrite branch from 6f61b11 to ae7eb4a Compare February 22, 2026 19:49
@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Feb 22, 2026

Yes, it supports --version=branch to track latest commit while keeping main version point to latest tag, see wiki.nixos.org/wiki/Nixpkgs/Automatic_Updates

Thanks, done!

@doronbehar doronbehar requested a review from qweered February 22, 2026 19:49
@qweered
Copy link
Copy Markdown
Contributor

qweered commented Feb 22, 2026

What about __structuredAttrs = true?

@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Feb 22, 2026

What about __structuredAttrs = true?

I didn't fully understand you earlier, and now I tried it and got:

Validating consistency between /build/source/package-lock.json and /nix/store/kgi3358kv8yp6ixv7g1n9js2kqdd57vn-Sharedown-5.3.6-unstable-2025-12-16-npm-deps/package-lock.json

thread 'main' (24) panicked at src/main.rs:153:58:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@pyrox0
Copy link
Copy Markdown
Member

pyrox0 commented Feb 22, 2026 •
edited
Loading

I believe there are incompatibilities with the npm deps fetcher with __structuredAttrs at the moment, so let's not worry about that for now. Once they get resolved, then it will probably get enabled on all buildNpmPackage-using packages anyways, so no need to manually set it here.

Changes otherwise lgtm.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 22, 2026
@doronbehar doronbehar added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Feb 22, 2026
@doronbehar doronbehar added this pull request to the merge queue Feb 22, 2026
Merged via the queue into NixOS:master with commit 3491130 Feb 22, 2026
30 of 33 checks passed
@doronbehar doronbehar deleted the pkg/sharedown@rewrite branch February 22, 2026 21:53
@nixpkgs-ci nixpkgs-ci bot removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyrox0 pyrox0 Awaiting requested review from pyrox0

1 more reviewer

@qweered qweered qweered approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doronbehar @qweered @pyrox0