Skip to content

qt5.qtbase: fix mysql support for cross builds#492858

Merged
doronbehar merged 1 commit intoNixOS:stagingfrom
doronbehar:pkg/qt5.qtbase@mysql
Mar 23, 2026
Merged

qt5.qtbase: fix mysql support for cross builds#492858
doronbehar merged 1 commit intoNixOS:stagingfrom
doronbehar:pkg/qt5.qtbase@mysql

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

@doronbehar doronbehar commented Feb 21, 2026 •
edited
Loading

Things done

  • Built on platform (when rebased upon branch master):
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@doronbehar doronbehar mentioned this pull request Feb 21, 2026
Closed
13 tasks
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Feb 21, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Feb 21, 2026
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 11, 2026
@doronbehar doronbehar requested a review from SFrijters March 19, 2026 15:41
@doronbehar
qt5.qtbase: fix mysql support for cross builds
3d07c38 
And fix build with strictDeps enabled

Co-Authored-By: eryngion <eryngion@protonmail.com>
@doronbehar doronbehar force-pushed the pkg/qt5.qtbase@mysql branch from 781f77c to 3d07c38 Compare March 19, 2026 15:43
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 19, 2026
@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Mar 23, 2026

Any chance for a review @SFrijters ? I'm asking because you have modified played with the qt5.qtbase expression...

@SFrijters
Copy link
Copy Markdown
Member

SFrijters commented Mar 23, 2026

The patch and supporting changes make sense to me and nothing looks dangerous in terms of regressing __structuredAttrs support - if you want me to try a structuredAttrs / cross build it'll take a while for my build machine to free up.

@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Mar 23, 2026

The patch and supporting changes make sense to me and nothing looks dangerous in terms of regressing __structuredAttrs support - if you want me to try a structuredAttrs / cross build it'll take a while for my build machine to free up.

I already did that TBH. If changes look good to you then I'll merge.

@doronbehar doronbehar added this pull request to the merge queue Mar 23, 2026
Merged via the queue into NixOS:staging with commit 460a6e5 Mar 23, 2026
28 of 30 checks passed
@doronbehar doronbehar deleted the pkg/qt5.qtbase@mysql branch March 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr Awaiting requested review from bkchr

@K900 K900 Awaiting requested review from K900

@NickCao NickCao Awaiting requested review from NickCao

@qknight qknight Awaiting requested review from qknight

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

@SFrijters SFrijters Awaiting requested review from SFrijters

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doronbehar @SFrijters