nixos/atticd: use garage in the test instead of minio#492528
Merged
Defelo merged 1 commit intoNixOS:masterfrom Mar 23, 2026
Merged
nixos/atticd: use garage in the test instead of minio#492528Defelo merged 1 commit intoNixOS:masterfrom
garage in the test instead of minio#492528Defelo merged 1 commit intoNixOS:masterfrom
Conversation
c4018e6 to
8b9e408
Compare
18 tasks
britter
approved these changes
Feb 20, 2026
8b9e408 to
365bb01
Compare
jpds
reviewed
Feb 21, 2026
Related NixOS#490996, `minio` is not supported upstream anymore.
365bb01 to
846b1a7
Compare
garage' in the test instead of minio`
garage' in the test instead of minio`garage in the test instead of minio
Contributor
|
@LeSuisse can we merge this? |
Member
Author
|
Ideally I try to not self-merge patches especially on stuff I do not maintain directly. That's said given it only impacts a test I will merge by the end of the week if there is no progress. |
Defelo
approved these changes
Mar 23, 2026
Member
Defelo
left a comment
There was a problem hiding this comment.
LGTM, test passes on x86_64-linux and aarch64-linux. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #490996,
miniois not supported upstream anymore.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.