Skip to content

arrow-cpp: disable S3 tests needing Minio#492170

Merged
nixpkgs-ci[bot] merged 1 commit intoNixOS:stagingfrom
LeSuisse:arrow-cpp-disable-mino-tests
Feb 20, 2026
Merged

arrow-cpp: disable S3 tests needing Minio#492170
nixpkgs-ci[bot] merged 1 commit intoNixOS:stagingfrom
LeSuisse:arrow-cpp-disable-mino-tests

Conversation

@LeSuisse
Copy link
Copy Markdown
Member

@LeSuisse LeSuisse commented Feb 19, 2026

The tests rely on minio which is has been abandoned upstream, see #490996. In order to reduce the number of packages that will be flagged as insecure once minio is tagged with knownVulnerabilities, we disable the arrow-cpp tests needing it.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@LeSuisse
arrow-cpp: disable S3 tests needing Minio
2246ee4 
The tests rely on `minio` which is has been abandoned upstream, see NixOS#490996.
In order to reduce the number of packages that will be flagged as insecure
once minio is tagged with `knownVulnerabilities`, we disable the arrow-cpp
tests needing it.
@LeSuisse LeSuisse mentioned this pull request Feb 19, 2026
Open
18 tasks
@nixpkgs-ci nixpkgs-ci bot requested review from cpcloud, tobim and veprbl February 19, 2026 16:55
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Feb 19, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 19, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 19, 2026
@tobim
Copy link
Copy Markdown
Contributor

tobim commented Feb 20, 2026

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci nixpkgs-ci bot added this pull request to the merge queue Feb 20, 2026
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Feb 20, 2026

@tobim wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
    • ⬜ Approved by a committer.
    • ⬜ Backported via label.
    • ✅ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ tobim is a member of @NixOS/nixpkgs-maintainers.
  • ✅ tobim is a maintainer of all touched packages.

✔️ Queued for merge (#306934)

Merged via the queue into NixOS:staging with commit e01fd75 Feb 20, 2026
37 of 40 checks passed
@LeSuisse LeSuisse deleted the arrow-cpp-disable-mino-tests branch February 20, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpcloud cpcloud Awaiting requested review from cpcloud

@veprbl veprbl Awaiting requested review from veprbl

2 more reviewers

@tobim tobim tobim approved these changes

@britter britter britter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeSuisse @tobim @britter