Skip to content

ceph: use with<Pkg> flags instead overriding packages to null#490276

Open
quantenzitrone wants to merge 2 commits intoNixOS:masterfrom
quantenzitrone:no-null-packages
Open

ceph: use with<Pkg> flags instead overriding packages to null#490276
quantenzitrone wants to merge 2 commits intoNixOS:masterfrom
quantenzitrone:no-null-packages

Conversation

@quantenzitrone
Copy link
Copy Markdown
Contributor

@quantenzitrone quantenzitrone commented Feb 14, 2026

to verify the changes, i split it into 2 commits:

  • the first commit doesn't create any rebuilds since it still overrides the packages to null if they are disabled
  • the second commit changes these null overrides to lib.optional and reorders some dependencies

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 14, 2026
@quantenzitrone quantenzitrone marked this pull request as ready for review February 14, 2026 02:31
@quantenzitrone
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 490276
Commit: 9adc2d42caf01aed652884ab809049eb37e0a9fb (subsequent changes)
Merge: b5f7202ebe205851385561f3e196a4131f746aa6

Logs: https://github.com/quantenzitrone/nixpkgs-review-gha/actions/runs/22184060189


x86_64-linux

✅ 14 packages built:
  • ceph (ceph-dev)
  • ceph-client (ceph-client.client, ceph-client.dev, ceph-client.doc, ceph-client.lib, ceph-client.man, ceph-dev.client, ceph.client)
  • ceph-csi
  • ceph.dev (ceph-dev.dev)
  • ceph.doc (ceph-dev.doc)
  • libceph (ceph.lib, libceph.client, libceph.dev, libceph.doc, libceph.lib, libceph.man)
  • ceph.man (ceph-dev.man)
  • qemu_full
  • qemu_full.debug
  • qemu_full.doc
  • qemu_full.ga
  • sambaFull (samba4Full)
  • sambaFull.dev (samba4Full.dev)
  • sambaFull.man (samba4Full.man)

aarch64-linux

✅ 11 packages built:
  • ceph (ceph-dev)
  • ceph-client (ceph-client.client, ceph-client.dev, ceph-client.doc, ceph-client.lib, ceph-client.man, ceph-dev.client, ceph.client)
  • ceph-csi
  • ceph.dev (ceph-dev.dev)
  • ceph.doc (ceph-dev.doc)
  • libceph (ceph.lib, libceph.client, libceph.dev, libceph.doc, libceph.lib, libceph.man)
  • ceph.man (ceph-dev.man)
  • qemu_full
  • qemu_full.debug
  • qemu_full.doc
  • qemu_full.ga

This was referenced Feb 27, 2026
@benaryorg
Copy link
Copy Markdown
Contributor

benaryorg commented Apr 12, 2026

We've managed to merge Ceph 20.2.1 in #494583 now (read: it's on master).
Would you be willing to rebase/redo this PR on top of that (rather big) change?
Otherwise I'd see whether I can eventually get around to doing so.
A fellow maintainer has also added some additional notes in a collapsible block in a comment, just in case they would be helpful.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants