compiler-rt: enable build of libatomic#488265
Merged
alyssais merged 1 commit intoNixOS:masterfrom Mar 7, 2026
Merged
Conversation
LLVM stdenvs lack a set of `__atomic_*` routines that compilers sometimes rely on, making it impossible to build certain C programs in them. The reason we lack these routines is that we're using neither compiler-rt's implementation of them (which was disabled by default a long time ago) nor gcc's implementation (libatomic). See NixOS#391740 for a more detailed explanation and an example of program that cannot be built. Since no particular preference was expressed as to which approach should be used to solve this, I'm going with LLVM's implementation and recommended setup, which seems to be used also in AIX, Fuchsia and Apple platforms. This consists of enabling a CMake flag, `COMPILER_RT_BUILD_STANDALONE_LIBATOMIC`, which causes the routines to be built and shipped in a separate DSO (placing them in a DSO instead of `builtins.a` is needed for correctness, as it ensures the lock section is unique in memory). As with the other builtins, I'm symlinking this DSO to `libatomic.so` so that downstream packages don't need specific/complicated logic for LLVM. Other details: - For static platforms, since no dynamic linking is expected at all, it should be correct to ship the symbols in `builtins.a`. So, that's what I'm doing in those cases. - Since v19, compiler-rt allows using pthread locks rather than ad-hoc ones for the atomic routines. Since this plays better with instrumentation, I'm enabling this whenever libc is available. - It would be nice to put the DSO in a separate output / derivation, so that the rest of compiler-rt isn't pulled into the runtime closure, but it isn't high prio since compiler-rt doesn't pull in dependencies other than libc, libc++ and unwinder. Fixes: NixOS#311930
Contributor
|
@RossComputerGuy PTAL, looks like the feedback in #398520 was addressed |
mildsunrise
approved these changes
Feb 9, 2026
Contributor
Author
|
@RossComputerGuy mind taking a look? |
Contributor
Author
|
@NixOS/llvm can somebody take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #398520.
Additional changes:
Credit goes to @mildsunrise.
Fixes: #311930
Tested with
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.