Skip to content

quantframe: 1.5.9 -> 1.6.12#484972

Merged
gepbird merged 1 commit into
NixOS:masterfrom
nyukuru:quantframe-upd
Feb 26, 2026
Merged

quantframe: 1.5.9 -> 1.6.12#484972
gepbird merged 1 commit into
NixOS:masterfrom
nyukuru:quantframe-upd

Conversation

@nyukuru

@nyukuru nyukuru commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

fixes: #476937

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nyukuru nyukuru requested a review from xNefas January 29, 2026 06:22
@nyukuru

nyukuru commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

I've created an issue for upstream to fix the desynced node/rust dependencies but for now it's patched manually

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 29, 2026
@nyukuru nyukuru mentioned this pull request Jan 29, 2026
Closed
13 tasks
@cybardev

cybardev commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 484972
Commit: 2f9dfa1d756e8be9e6f0ea1a26e11fca692765aa (subsequent changes)
Merge: 8948ee6918a4478c211a337b8d39f975d40639e8

Logs: https://github.com/cybardev/nixpkgs-review-action/actions/runs/21468664275

x86_64-linux

✅ 1 package built:
  • quantframe

aarch64-linux

✅ 1 package built:
  • quantframe

@xNefas

xNefas commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 484972
Commit: 2f9dfa1d756e8be9e6f0ea1a26e11fca692765aa

x86_64-linux

✅ 1 package built:
  • quantframe

@xNefas

xNefas commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 484972 Commit: 2f9dfa1d756e8be9e6f0ea1a26e11fca692765aa

x86_64-linux

✅ 1 package built:

Getting these error lines when trying to play the audio that should be played when receiving a notification, which also freezes the application.

GStreamer element appsink not found. Please install it.
GStreamer element autoaudiosink not found. Please install it

(WebKitWebProcess:1937649): GLib-GObject-CRITICAL **: 04:40:26.071: invalid (NULL) pointer instance

(WebKitWebProcess:1937649): GLib-GObject-CRITICAL **: 04:40:26.071: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

The most relevant issues and context I could find to this is this issue on Tauri.

Installing gst_all_1.gst-plugins-base, gst_all_1.gst-plugins-good and gst_all_1.gstreamer did not solve the issue, although I believe there's more context in this reply to an issue in OpenTaiko-Hub

@nyukuru

nyukuru commented Feb 1, 2026

Copy link
Copy Markdown
Contributor Author

Installing gst_all_1.gst-plugins-base, gst_all_1.gst-plugins-good and gst_all_1.gstreamer did not solve the issue

Worked fine for me...

@xNefas

xNefas commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Installing gst_all_1.gst-plugins-base, gst_all_1.gst-plugins-good and gst_all_1.gstreamer did not solve the issue

Worked fine for me...

Could you please describe the steps you took to make the aforementioned feature work?

I mentioned that I "installed" those packages, but didn't have the time when testing this PR with nixpkgs-review to actually install them system-wide, and simply used a temporary shell.
I've got much more to learn about Nix, so if there's any sort of nuance or detail in which nixpkgs-review omits temporary shell packages or similar behaviour, let me know :)

@qweered qweered mentioned this pull request Feb 26, 2026
Closed
13 tasks
@qweered qweered requested a review from gepbird February 26, 2026 19:15
@qweered qweered mentioned this pull request Feb 26, 2026
Closed
15 tasks
@qweered

qweered commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 484972
Commit: 7cd04d14f37d13e5064f33fedfb5efedbb0af4a8 (subsequent changes)
Merge: 7d720d7bbb9775ea147ea0a344d53f7f4bd3123f

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/22457327903

x86_64-linux

✅ 1 package built:
  • quantframe

aarch64-linux

✅ 1 package built:
  • quantframe

qweered
qweered approved these changes Feb 26, 2026
View reviewed changes

@qweered qweered left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 26, 2026
gepbird
gepbird approved these changes Feb 26, 2026
View reviewed changes

@gepbird gepbird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Diff looks good, I tested the very basics of the binary that the GUI opens.

@gepbird gepbird added this pull request to the merge queue Feb 26, 2026
Merged via the queue into NixOS:master with commit f4b0c54 Feb 26, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gepbird gepbird gepbird approved these changes

@xNefas xNefas Awaiting requested review from xNefas

+1 more reviewer

@qweered qweered qweered approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Quantframe fails to build on unstable

5 participants

@nyukuru @cybardev @xNefas @qweered @gepbird